linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <j@w1.fi>, John Linville <linville@tuxdriver.com>,
	wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] hostap: Fix sparse warnings
Date: Thu, 16 Oct 2008 16:43:36 -0700	[thread overview]
Message-ID: <48F7D1A8.4090608@lwfinger.net> (raw)
In-Reply-To: <1224172212.735.79.camel@johannes.berg>

Johannes Berg wrote:
> On Thu, 2008-10-16 at 08:46 -0700, Larry Finger wrote:
> 
>> -	set_bit(PRISM2_INFO_PENDING_LINKSTATUS, &local->pending_info);
>> +	set_bit(PRISM2_INFO_PENDING_LINKSTATUS, (ulong *)&local->pending_info);
> 
> Shouldn't you just do this instead?
> 
> 
> --- hostapd_wlan.h
> +++ hostapd_wlan.h
> @@ ... @@
> -	long pending_info;
> +	unsigned long pending_info;

Yes. V2 of the patch coming.

Thanks,

Larry


  reply	other threads:[~2008-10-16 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 15:46 [PATCH] hostap: Fix sparse warnings Larry Finger
2008-10-16 15:50 ` Johannes Berg
2008-10-16 23:43   ` Larry Finger [this message]
2008-10-16 23:44 ` [PATCH V2] " Larry Finger
2008-10-19 14:29   ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F7D1A8.4090608@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).