* [PATCH] hostap: Fix sparse warnings
@ 2008-10-16 15:46 Larry Finger
2008-10-16 15:50 ` Johannes Berg
2008-10-16 23:44 ` [PATCH V2] " Larry Finger
0 siblings, 2 replies; 5+ messages in thread
From: Larry Finger @ 2008-10-16 15:46 UTC (permalink / raw)
To: Jouni Malinen, John Linville; +Cc: wireless
A compilation with the command "make C=2 CF="-D__CHECK_ENDIAN__" \
drivers/net/wireless/hostap/"
yields the following warnings:
CHECK drivers/net/wireless/hostap/hostap_info.c
drivers/net/wireless/hostap/hostap_info.c:156:43: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:156:43: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:156:43: got long *<noident>
drivers/net/wireless/hostap/hostap_info.c:294:44: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:294:44: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:294:44: got long *<noident>
drivers/net/wireless/hostap/hostap_info.c:487:12: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:487:12: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:487:12: got long *<noident>
drivers/net/wireless/hostap/hostap_info.c:491:12: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:491:12: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:491:12: got long *<noident>
The warnings are fixed with the following compile-tested changes:
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/net/wireless/hostap/hostap_info.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/hostap/hostap_info.c
+++ wireless-testing/drivers/net/wireless/hostap/hostap_info.c
@@ -153,7 +153,7 @@ static void prism2_info_linkstatus(local
}
/* Get current BSSID later in scheduled task */
- set_bit(PRISM2_INFO_PENDING_LINKSTATUS, &local->pending_info);
+ set_bit(PRISM2_INFO_PENDING_LINKSTATUS, (ulong *)&local->pending_info);
local->prev_link_status = val;
schedule_work(&local->info_queue);
}
@@ -291,7 +291,7 @@ static void prism2_info_scanresults(loca
hostap_report_scan_complete(local);
/* Perform rest of ScanResults handling later in scheduled task */
- set_bit(PRISM2_INFO_PENDING_SCANRESULTS, &local->pending_info);
+ set_bit(PRISM2_INFO_PENDING_SCANRESULTS, (ulong *)&local->pending_info);
schedule_work(&local->info_queue);
}
@@ -484,11 +484,11 @@ static void handle_info_queue(struct wor
local_info_t *local = container_of(work, local_info_t, info_queue);
if (test_and_clear_bit(PRISM2_INFO_PENDING_LINKSTATUS,
- &local->pending_info))
+ (ulong *)&local->pending_info))
handle_info_queue_linkstatus(local);
if (test_and_clear_bit(PRISM2_INFO_PENDING_SCANRESULTS,
- &local->pending_info))
+ (ulong *)&local->pending_info))
handle_info_queue_scanresults(local);
}
#endif /* PRISM2_NO_STATION_MODES */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hostap: Fix sparse warnings
2008-10-16 15:46 [PATCH] hostap: Fix sparse warnings Larry Finger
@ 2008-10-16 15:50 ` Johannes Berg
2008-10-16 23:43 ` Larry Finger
2008-10-16 23:44 ` [PATCH V2] " Larry Finger
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2008-10-16 15:50 UTC (permalink / raw)
To: Larry Finger; +Cc: Jouni Malinen, John Linville, wireless
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
On Thu, 2008-10-16 at 08:46 -0700, Larry Finger wrote:
> - set_bit(PRISM2_INFO_PENDING_LINKSTATUS, &local->pending_info);
> + set_bit(PRISM2_INFO_PENDING_LINKSTATUS, (ulong *)&local->pending_info);
Shouldn't you just do this instead?
--- hostapd_wlan.h
+++ hostapd_wlan.h
@@ ... @@
- long pending_info;
+ unsigned long pending_info;
?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hostap: Fix sparse warnings
2008-10-16 15:50 ` Johannes Berg
@ 2008-10-16 23:43 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2008-10-16 23:43 UTC (permalink / raw)
To: Johannes Berg; +Cc: Jouni Malinen, John Linville, wireless
Johannes Berg wrote:
> On Thu, 2008-10-16 at 08:46 -0700, Larry Finger wrote:
>
>> - set_bit(PRISM2_INFO_PENDING_LINKSTATUS, &local->pending_info);
>> + set_bit(PRISM2_INFO_PENDING_LINKSTATUS, (ulong *)&local->pending_info);
>
> Shouldn't you just do this instead?
>
>
> --- hostapd_wlan.h
> +++ hostapd_wlan.h
> @@ ... @@
> - long pending_info;
> + unsigned long pending_info;
Yes. V2 of the patch coming.
Thanks,
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] hostap: Fix sparse warnings
2008-10-16 15:46 [PATCH] hostap: Fix sparse warnings Larry Finger
2008-10-16 15:50 ` Johannes Berg
@ 2008-10-16 23:44 ` Larry Finger
2008-10-19 14:29 ` Jouni Malinen
1 sibling, 1 reply; 5+ messages in thread
From: Larry Finger @ 2008-10-16 23:44 UTC (permalink / raw)
To: Jouni Malinen, John Linville; +Cc: wireless
A compilation with the command "make C=2 CF="-D__CHECK_ENDIAN__" \
drivers/net/wireless/hostap/"
yields the following warnings:
CHECK drivers/net/wireless/hostap/hostap_info.c
drivers/net/wireless/hostap/hostap_info.c:156:43: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:156:43: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:156:43: got long *<noident>
drivers/net/wireless/hostap/hostap_info.c:294:44: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:294:44: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:294:44: got long *<noident>
drivers/net/wireless/hostap/hostap_info.c:487:12: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:487:12: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:487:12: got long *<noident>
drivers/net/wireless/hostap/hostap_info.c:491:12: warning: incorrect type in
argument 2 (different signedness)
drivers/net/wireless/hostap/hostap_info.c:491:12: expected unsigned long
volatile *addr
drivers/net/wireless/hostap/hostap_info.c:491:12: got long *<noident>
The warnings are fixed with the following compile-tested fix:
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/net/wireless/hostap/hostap_wlan.h
===================================================================
--- wireless-testing.orig/drivers/net/wireless/hostap/hostap_wlan.h
+++ wireless-testing/drivers/net/wireless/hostap/hostap_wlan.h
@@ -822,7 +822,7 @@ struct local_info {
int last_scan_results_count;
enum { PRISM2_SCAN, PRISM2_HOSTSCAN } last_scan_type;
struct work_struct info_queue;
- long pending_info; /* bit field of pending info_queue items */
+ unsigned long pending_info; /* bit field of pending info_queue items */
#define PRISM2_INFO_PENDING_LINKSTATUS 0
#define PRISM2_INFO_PENDING_SCANRESULTS 1
int prev_link_status; /* previous received LinkStatus info */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] hostap: Fix sparse warnings
2008-10-16 23:44 ` [PATCH V2] " Larry Finger
@ 2008-10-19 14:29 ` Jouni Malinen
0 siblings, 0 replies; 5+ messages in thread
From: Jouni Malinen @ 2008-10-19 14:29 UTC (permalink / raw)
To: Larry Finger; +Cc: John Linville, wireless
On Thu, Oct 16, 2008 at 04:44:03PM -0700, Larry Finger wrote:
> CHECK drivers/net/wireless/hostap/hostap_info.c
> drivers/net/wireless/hostap/hostap_info.c:156:43: warning: incorrect type in
> argument 2 (different signedness)
> drivers/net/wireless/hostap/hostap_info.c:156:43: expected unsigned long
> volatile *addr
> drivers/net/wireless/hostap/hostap_info.c:156:43: got long *<noident>
> The warnings are fixed with the following compile-tested fix:
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
This V2 looks good.
Acked-by: Jouni Malinen <j@w1.fi>
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-10-19 14:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-16 15:46 [PATCH] hostap: Fix sparse warnings Larry Finger
2008-10-16 15:50 ` Johannes Berg
2008-10-16 23:43 ` Larry Finger
2008-10-16 23:44 ` [PATCH V2] " Larry Finger
2008-10-19 14:29 ` Jouni Malinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).