From: John Daiker <daikerjohn@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: stefano.brivio@polimi.it, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: reduce checkpatch.pl errors
Date: Fri, 17 Oct 2008 14:58:28 -0700 [thread overview]
Message-ID: <48F90A84.60902@gmail.com> (raw)
In-Reply-To: <200810172345.52581.mb@bu3sch.de>
Michael Buesch wrote:
> On Friday 17 October 2008 23:36:36 John Daiker wrote:
>
>> - if (1 /*FIXME: the last PSpoll frame was sent successfully */ )
>> + if (1) /*FIXME: the last PSpoll frame was sent successfully */ {
>>
>
> Well, go for this, if you're really forced to fix this. ;)
>
>
>>> One additional thing I'd like you to do.
>>> Do a b43 compile before and after applying the patch.
>>> Keep the b43.ko files for both runs and do an md5sum on them.
>>> Add the results to the commit log. The sums _must_ match.
>>> If they don't, please send the changes that change the actual
>>> binary code in seperate patches.
>>>
>>>
>> Will do this next time with updated patch, among other things.
>>
>
> Thanks. Also make sure to enable all kconfig options.
> (also remove the BROKEN dependencies that some options have,
> if you are changing files related to these options.)
I'm assuming you're debugging and forcing PIO over DMA?
For the BROKEN things, can I just remove 'BROKEN' from the Kconfig
depends line?
next prev parent reply other threads:[~2008-10-17 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 19:16 [PATCH] b43: reduce checkpatch.pl errors John Daiker
2008-10-17 21:02 ` Michael Buesch
2008-10-17 21:36 ` John Daiker
2008-10-17 21:45 ` Michael Buesch
2008-10-17 21:58 ` John Daiker [this message]
2008-10-17 22:22 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F90A84.60902@gmail.com \
--to=daikerjohn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).