* [PATCH] Fix debugfs_create_bool's error checking method for wireless/iwlwifi/
@ 2008-10-22 9:06 Zhaolei
0 siblings, 0 replies; only message in thread
From: Zhaolei @ 2008-10-22 9:06 UTC (permalink / raw)
To: linux-kernel; +Cc: yi.zhu, reinette.chatre, linux-wireless, ipw3945-devel
Hi,
debugfs_create_bool() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
drivers/net/wireless/iwlwifi/iwl-debugfs.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-debugfs.c b/drivers/net/wireless/iwlwifi/iwl-debugfs.c
index 20db0eb..5346ed5 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debugfs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-debugfs.c
@@ -58,7 +58,8 @@
#define DEBUGFS_ADD_BOOL(name, parent, ptr) do { \
dbgfs->dbgfs_##parent##_files.file_##name = \
debugfs_create_bool(#name, 0644, dbgfs->dir_##parent, ptr); \
- if (IS_ERR(dbgfs->dbgfs_##parent##_files.file_##name)) \
+ if (IS_ERR(dbgfs->dbgfs_##parent##_files.file_##name) \
+ || !dbgfs->dbgfs_##parent##_files.file_##name) \
goto err; \
} while (0)
-- 1.5.5.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-22 9:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-22 9:06 [PATCH] Fix debugfs_create_bool's error checking method for wireless/iwlwifi/ Zhaolei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).