From: Larry Finger <Larry.Finger@lwfinger.net>
To: John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] mac80211: Fix warning in minstrel rate control
Date: Wed, 22 Oct 2008 16:18:39 -0700 [thread overview]
Message-ID: <48FFB4CF.5090704@lwfinger.net> (raw)
When compiling the minstrel rate-control code on x86_64 architecture, the
following warning is issued:
CC [M] net/mac80211/rc80211_minstrel_debugfs.o
net/mac80211/rc80211_minstrel_debugfs.c:145: warning: initialization from
incompatible pointer type
The fix requires changing the type of minstrel_stats_read().
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This warning also prints in mainline - this belongs in 2.6.28.
Larry
---
Index: linux-2.6/net/mac80211/rc80211_minstrel_debugfs.c
===================================================================
--- linux-2.6.orig/net/mac80211/rc80211_minstrel_debugfs.c
+++ linux-2.6/net/mac80211/rc80211_minstrel_debugfs.c
@@ -106,7 +106,7 @@ minstrel_stats_open(struct inode *inode,
return 0;
}
-static int
+static ssize_t
minstrel_stats_read(struct file *file, char __user *buf, size_t len, loff_t *o)
{
struct minstrel_stats_info *ms;
reply other threads:[~2008-10-22 23:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FFB4CF.5090704@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).