Re: [PATCH wireless-next v3 04/15] wifi: cfg80211/mac80211: Add NL80211_IFTYPE_PD for PD PASN and PMSR operations

[Peddolla Harshavardhan Reddy <peddolla.reddy@oss.qualcomm.com>]

On 13-Mar-26 2:36 AM, Stern, Avraham wrote:
>> From: Peddolla Harshavardhan Reddy <peddolla.reddy@oss.qualcomm.com> > Sent: Thursday, March 5, 2026 6:07 PM
>> To: johannes@sipsolutions.net
>> Cc: linux-wireless@vger.kernel.org; kavita.kavita@oss.qualcomm.com
>> Subject: [PATCH wireless-next v3 04/15] wifi: cfg80211/mac80211: Add NL80211_IFTYPE_PD for PD PASN and PMSR operations
>> Add a new wdev-only interface type NL80211_IFTYPE_PD to support Proximity Detection (PD) operations such as PASN, key install and peer measurement operations. This interface type operates without a netdev, similar to P2P_DEVICE and NAN interfaces.
> What about PD discovery?

PD discovery can happen on any interface. So we are not restricting it.


>
>> The PD interface provides isolated functionality for PD PASN and PMSR without affecting existing network operations.
> So PMSR will be allowed on station interface (for sta to AP measurements, when possibly associated and have security context already), and on the new interface type for non-AP ranging?

Yes, This is correct.


>
>> @@ -1935,6 +1938,7 @@ static void ieee80211_setup_sdata(struct ieee80211_sub_if_data *sdata,
>>  		break;
>>  	case NL80211_IFTYPE_AP_VLAN:
>>  	case NL80211_IFTYPE_P2P_DEVICE:
>> +	case NL80211_IFTYPE_PD:
>>  		sdata->vif.bss_conf.bssid = sdata->vif.addr;
>>  		break;
>  
> bss_conf is irrelevant for PD interface 


Fixed it in next version.

>
>> @@ -898,6 +898,7 @@ int ieee80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
>>  		need_offchan = true;
>>  		break;
>>  	case NL80211_IFTYPE_NAN:
>> +	case NL80211_IFTYPE_PD:
>>  		break;
> PD interface doesn't have a channel context, so set need_offchan = true?

Fixed it in the next version.


>
>> @@ -4621,6 +4621,7 @@ static bool ieee80211_accept_frame(struct ieee80211_rx_data *rx)
>>  			(ieee80211_is_public_action(hdr, skb->len) ||
>>  			 (ieee80211_is_auth(hdr->frame_control) &&
>>  			  ether_addr_equal(sdata->vif.addr, hdr->addr1)));
>> +	case NL80211_IFTYPE_PD:
>> 	default:
>> 		break;
>  
> At least check addr1, and accept only auth frames (PASN) and if used for discovery, also public action.

Added check for addr1 and accept only auth frames but support of public action can be added if needed.


>
>> @@ -13954,6 +13962,11 @@ static int nl80211_register_mgmt(struct sk_buff *skb, struct genl_info *info)
>>  		      WIPHY_NAN_FLAGS_USERSPACE_DE))
>> 			return -EOPNOTSUPP;
>> 		break;
>> +	case NL80211_IFTYPE_PD:
>> +		if (!wiphy_ext_feature_isset(wdev->wiphy,
>> +					     NL80211_EXT_FEATURE_SECURE_RTT))
>> +			return -EOPNOTSUPP;
>> +		break;
> So not used for PD discovery, why?


This is not restricted for this interface, support can be added in the future.

>
> ---------------------------------------------------------------------
> A member of the Intel Corporation group of companies
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>