[PATCH] p54: don't report known but unhandled EEPROM codes as unknown

[PATCH] p54: don't report known but unhandled EEPROM codes as unknown

[Pavel Roskin]

Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 drivers/net/wireless/p54/p54common.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
index 02a306d..29daa5d 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -416,6 +416,30 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
 			/* make it overrun */
 			entry_len = len;
 			break;
+		case PDR_MANUFACTURING_PART_NUMBER:
+		case PDR_PDA_VERSION:
+		case PDR_NIC_SERIAL_NUMBER:
+		case PDR_REGULATORY_DOMAIN_LIST:
+		case PDR_TEMPERATURE_TYPE:
+		case PDR_PRISM_PCI_IDENTIFIER:
+		case PDR_COUNTRY_INFORMATION:
+		case PDR_OEM_NAME:
+		case PDR_PRODUCT_NAME:
+		case PDR_UTF8_OEM_NAME:
+		case PDR_UTF8_PRODUCT_NAME:
+		case PDR_COUNTRY_LIST:
+		case PDR_DEFAULT_COUNTRY:
+		case PDR_ANTENNA_GAIN:
+		case PDR_PRISM_INDIGO_PA_CALIBRATION_DATA:
+		case PDR_RSSI_LINEAR_APPROXIMATION:
+		case PDR_RSSI_LINEAR_APPROXIMATION_DUAL_BAND:
+		case PDR_REGULATORY_POWER_LIMITS:
+		case PDR_RSSI_LINEAR_APPROXIMATION_EXTENDED:
+		case PDR_RADIATED_TRANSMISSION_CORRECTION:
+		case PDR_PRISM_TX_IQ_CALIBRATION:
+		case PDR_BASEBAND_REGISTERS:
+		case PDR_PER_CHANNEL_BASEBAND_REGISTERS:
+			break;
 		default:
 			printk(KERN_INFO "p54: unknown eeprom code : 0x%x\n",
 				le16_to_cpu(entry->code));

Re: [PATCH] p54: don't report known but unhandled EEPROM codes as unknown

[Larry Finger]

Pavel Roskin wrote:
> Signed-off-by: Pavel Roskin <proski@gnu.org>
> ---
>  drivers/net/wireless/p54/p54common.c |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 

ACK - This patch cleans up my logs.

Larry

Re: [PATCH] p54: don't report known but unhandled EEPROM codes as unknown

[Chr]

On Wednesday 29 October 2008 22:31:43 Pavel Roskin wrote:
> [...]
> +		case PDR_RADIATED_TRANSMISSION_CORRECTION:
> +		case PDR_PRISM_TX_IQ_CALIBRATION:
> +		case PDR_BASEBAND_REGISTERS:
> +		case PDR_PER_CHANNEL_BASEBAND_REGISTERS:
> +			break;
>  		default:
>  			printk(KERN_INFO "p54: unknown eeprom code : 0x%x\n",
>  				le16_to_cpu(entry->code));

what about removing the printk?
since intersil reserved 0x8000-0xffff for it's customers...
so there could be lots of unknown pdr magics.

Regards,
	Chr

Re: [PATCH] p54: don't report known but unhandled EEPROM codes as unknown

[Pavel Roskin]

On Thu, 2008-10-30 at 18:10 +0100, Chr wrote:
> On Wednesday 29 October 2008 22:31:43 Pavel Roskin wrote:
> > [...]
> > +		case PDR_RADIATED_TRANSMISSION_CORRECTION:
> > +		case PDR_PRISM_TX_IQ_CALIBRATION:
> > +		case PDR_BASEBAND_REGISTERS:
> > +		case PDR_PER_CHANNEL_BASEBAND_REGISTERS:
> > +			break;
> >  		default:
> >  			printk(KERN_INFO "p54: unknown eeprom code : 0x%x\n",
> >  				le16_to_cpu(entry->code));
> 
> what about removing the printk?
> since intersil reserved 0x8000-0xffff for it's customers...
> so there could be lots of unknown pdr magics.

I don't see any extra messages.  From my experience, OEMs don't change
anything except the required settings (IDs, OEM name, country code) and
don't add anything non-trivial.

But I'm fine either way, with or without that printk.

-- 
Regards,
Pavel Roskin