linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: John Linville <linville@tuxdriver.com>
Cc: htl10@users.sourceforge.net,
	Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
	Pavel Roskin <proski@gnu.org>,
	wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH 5/6] rtl8187: Remove primitive write delays
Date: Fri, 31 Oct 2008 09:54:30 -0700	[thread overview]
Message-ID: <490B3846.8030705@lwfinger.net> (raw)
In-Reply-To: <49088F7D.8020102@lwfinger.net>

Each of the primary write routines, rtl8187_write_phy(),
rtl8225_write_bitbang(), and rtl8225_write_8051() all conclude with an
msleep() command. Testing shows that these are not needed.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Tested-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Tested-by: Hin-Tak Leung <htl10@users.sourceforge.net>
---

John,

This is 2.6.29 material.

Larry
---

Index: wireless-testing/drivers/net/wireless/rtl8187_dev.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl8187_dev.c
+++ wireless-testing/drivers/net/wireless/rtl8187_dev.c
@@ -152,8 +152,6 @@ void rtl8187_write_phy(struct ieee80211_
 	rtl818x_iowrite8(priv, &priv->map->PHY[2], (data >> 16) & 0xFF);
 	rtl818x_iowrite8(priv, &priv->map->PHY[1], (data >> 8) & 0xFF);
 	rtl818x_iowrite8(priv, &priv->map->PHY[0], data & 0xFF);
-
-	msleep(1);
 }

 static void rtl8187_tx_cb(struct urb *urb)
Index: wireless-testing/drivers/net/wireless/rtl8187_rtl8225.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl8187_rtl8225.c
+++ wireless-testing/drivers/net/wireless/rtl8187_rtl8225.c
@@ -64,7 +64,6 @@ static void rtl8225_write_bitbang(struct

 	rtl818x_iowrite16(priv, &priv->map->RFPinsOutput, reg80 | (1 << 2));
 	rtl818x_iowrite16(priv, &priv->map->RFPinsSelect, reg84);
-	msleep(2);
 }

 static void rtl8225_write_8051(struct ieee80211_hw *dev, u8 addr, __le16 data)
@@ -98,7 +97,6 @@ static void rtl8225_write_8051(struct ie

 	rtl818x_iowrite16(priv, &priv->map->RFPinsOutput, reg80 | (1 << 2));
 	rtl818x_iowrite16(priv, &priv->map->RFPinsSelect, reg84);
-	msleep(2);
 }

 static void rtl8225_write(struct ieee80211_hw *dev, u8 addr, u16 data)






  parent reply	other threads:[~2008-10-31 16:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <838057.50079.qm@web23102.mail.ird.yahoo.com>
2008-10-29 16:29 ` [RFC/RFT] rtl8187: Reduce delays to reduce startup time Larry Finger
2008-10-29 18:42   ` Herton Ronaldo Krzesinski
2008-10-29 19:38     ` Hin-Tak Leung
2008-10-30  0:48       ` Larry Finger
2008-10-30  0:49   ` [RFC/RFT PATCH 0/6] " Larry Finger
2008-10-30  0:52   ` [RFC/RFT PATCH 2/6] rtl8187: Remove OFDM delays Larry Finger
2008-10-30  0:53   ` [RFC/RFT PATCH 3/6] rtl8187: Remove CCK delays Larry Finger
2008-10-30  0:54   ` [RFC/RFT PATCH 6/6] rtl8187: Reduce channel switch delay Larry Finger
2008-10-30  0:54   ` [RFC/RFT PATCH 1/6] rtl8187: Remove large delays Larry Finger
2008-10-30  0:54   ` [RFC/RFT PATCH 4/6] rtl8187: Remove msleep calls after calls to rtl8225_write Larry Finger
2008-10-30  0:55   ` [RFC/RFT PATCH 5/6] rtl8187: Remove primitive write delays Larry Finger
2008-10-30 16:51     ` [RFC/RFT] rtl8187: Change TX power settings Larry Finger
2008-10-30 18:52       ` Hin-Tak Leung
2008-10-30 23:42         ` Larry Finger
2008-10-31  3:29       ` Piter PUNK
2008-10-31 16:51   ` [PATCH 0/6] rtl8187: Reduce delays to reduce startup time Larry Finger
2008-10-31 18:03     ` Herton Ronaldo Krzesinski
2008-10-31 16:52   ` [PATCH 1/6] rtl8187: Remove large delays Larry Finger
2008-10-31 16:52   ` [PATCH 2/6] rtl8187: Remove OFDM delays Larry Finger
2008-10-31 16:52   ` [PATCH 3/6] rtl8187: Remove CCK delays Larry Finger
2008-10-31 16:54   ` [PATCH 4/6] rtl8187: Remove msleep calls after calls to rtl8225_write Larry Finger
2008-10-31 16:54   ` Larry Finger [this message]
2008-10-31 16:54   ` [PATCH 6/6] rtl8187: Reduce channel switch delay Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490B3846.8030705@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=herton@mandriva.com.br \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).