From: Larry Finger <Larry.Finger@lwfinger.net>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: linux-wireless@vger.kernel.org,
Hin-Tak Leung <htl10@users.sourceforge.net>,
John W Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Michael Wu <flamingice@sourmilk.net>,
Andrea Merello <andrea.merello@gmail.com>
Subject: Re: [RFC/RFT PATCH v2 2/2] rtl8187: feedback transmitted packets using tx close descriptor for 8187B
Date: Tue, 04 Nov 2008 14:31:30 -0800 [thread overview]
Message-ID: <4910CD42.4010402@lwfinger.net> (raw)
In-Reply-To: <1225806649-10050-3-git-send-email-herton@mandriva.com.br>
Herton Ronaldo Krzesinski wrote:
> Realtek 8187B has a receive command queue to feedback beacon interrupt
> and transmitted packet status. Use it to feedback mac80211 about status
> of transmitted packets. Unfortunately in the course of testing I found
> that the sequence number reported by hardware includes entire sequence
> control in a 12 bit only field, so a workaround is done to check only
> lowest bits.
>
> Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Quilt shows the following warning:
Warning: trailing whitespace in lines 438,468 of drivers/net/wireless/rtl8187_dev.c
scripts/checkpatch shows the following:
WARNING: line over 80 characters
#138: FILE: drivers/net/wireless/rtl8187_dev.c:475:
+ if ((le16_to_cpu(ieee80211hdr->seq_ctrl) & 0xFFF) == seq_no)
total: 0 errors, 1 warnings, 173 lines checked
Larry
next prev parent reply other threads:[~2008-11-04 22:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 13:50 [RFC/RFT PATCH 0/2 v2] rtl8187: implement conf_tx callback/correctly ack tx pkts Herton Ronaldo Krzesinski
2008-11-04 13:50 ` [RFC/RFT PATCH v2 1/2] rtl8187: implement conf_tx callback to configure tx queues Herton Ronaldo Krzesinski
2008-11-04 22:30 ` Larry Finger
2008-11-04 23:11 ` Felix Fietkau
2008-11-05 15:33 ` Herton Ronaldo Krzesinski
2008-11-04 13:50 ` [RFC/RFT PATCH v2 2/2] rtl8187: feedback transmitted packets using tx close descriptor for 8187B Herton Ronaldo Krzesinski
2008-11-04 20:27 ` Hin-Tak Leung
2008-11-04 21:30 ` Herton Ronaldo Krzesinski
2008-11-04 22:31 ` Larry Finger [this message]
2008-11-05 11:29 ` Johannes Berg
2008-11-05 15:38 ` Herton Ronaldo Krzesinski
2008-11-05 15:40 ` Johannes Berg
2008-11-05 15:59 ` Herton Ronaldo Krzesinski
-- strict thread matches above, loose matches on Subject: below --
2008-11-05 2:02 Hin-Tak Leung
2008-11-05 15:42 ` Herton Ronaldo Krzesinski
2008-11-05 17:11 ` Hin-Tak Leung
2008-11-05 21:36 ` Herton Ronaldo Krzesinski
2008-11-05 22:05 ` Hin-Tak Leung
2008-11-05 22:43 ` Luis R. Rodriguez
2008-11-05 23:16 ` Hin-Tak Leung
2008-11-05 23:35 ` Luis R. Rodriguez
2008-11-06 14:14 ` John W. Linville
2008-11-06 18:53 ` Luis R. Rodriguez
2008-11-06 0:00 ` Hin-Tak Leung
2008-11-06 0:18 ` Larry Finger
2008-11-06 1:02 ` Hin-Tak Leung
2008-11-06 1:36 ` Hin-Tak Leung
2008-11-06 1:42 ` Larry Finger
2008-11-06 4:23 ` Hin-Tak Leung
2008-11-06 20:49 ` Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4910CD42.4010402@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andrea.merello@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).