linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net, "Halperin,
	Daniel C" <daniel.c.halperin@intel.com>,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: [PATCH 05/13] iwlwifi: update iwl-commands.h for 3 stream support
Date: Sat, 08 Nov 2008 06:51:49 +0100	[thread overview]
Message-ID: <491528F5.3070408@holtmann.org> (raw)
In-Reply-To: <1226080726-24860-6-git-send-email-reinette.chatre@intel.com>

Hi Reinette,

> From: Halperin, Daniel C <daniel.c.halperin@intel.com>
> 
> This patch updates comments and constants to support 1, 2, or 3 spatial streams
> in rate_n_flags .
> 
> Signed-off-by: Daniel Halperin <daniel.c.halperin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

so this has been mentioned before, but lets do it again. Since you are 
the person who sends the patches upstream, your Signed-off-by line has 
to be the last one. If you ever touched the patch, looked at it or not 
makes no difference here. The line is just there to track the steps it 
made into mainline.

The original or main author is of course the first Signed-off-by line.

So with patch I assume that Daniel send the patch to Tomas and then 
Tomas queued them up and send a bunch of patches to you. If Tomas just 
reviewed the patch, I like really to see the proper Acked-by lines in 
between in the future.

Also there is no problem if we start adding Tested-by from the people 
that actually run validation tests of the patches.

Regards

Marcel


  parent reply	other threads:[~2008-11-08  4:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 17:58 [PATCH 0/13] iwlwifi driver updates Reinette Chatre
2008-11-07 17:58 ` [PATCH 01/13] iwlagn: fix resume for ADHOC network Reinette Chatre
2008-11-07 17:58   ` [PATCH 02/13] iwl3945: " Reinette Chatre
2008-11-07 17:58     ` [PATCH 03/13] iwlwifi: trivial fix in includes Reinette Chatre
2008-11-07 17:58       ` [PATCH 04/13] iwlwifi: don't fail power set when calibration is not done yet Reinette Chatre
2008-11-07 17:58         ` [PATCH 05/13] iwlwifi: update iwl-commands.h for 3 stream support Reinette Chatre
2008-11-07 17:58           ` [PATCH 06/13] iwlwifi: move rx queue read pointer into rxq Reinette Chatre
2008-11-07 17:58             ` [PATCH 07/13] iwlwifi: revamp tx scheduler byte count tables handling Reinette Chatre
2008-11-07 17:58               ` [PATCH 08/13] iwlwifi: move spectrum measurement code to iwl-spectrum.c file Reinette Chatre
2008-11-07 17:58                 ` [PATCH 09/13] iwl3945 : Fix Sparse Warnings Reinette Chatre
2008-11-07 17:58                   ` [PATCH 10/13] iwlwifi: move iwl_print_hex_dump to iwl-debug.h Reinette Chatre
2008-11-07 17:58                     ` [PATCH 11/13] iwl3945 : Simplify iwl3945_send_beacon_cmd Reinette Chatre
2008-11-07 17:58                       ` [PATCH 12/13] iwlwifi: get some more information about command failure Reinette Chatre
2008-11-07 17:58                         ` [PATCH 13/13] iwlwifi: use Rx single frame mode (one Rx frame per RB) Reinette Chatre
2008-11-07 18:09                       ` [PATCH 11/13] iwl3945 : Simplify iwl3945_send_beacon_cmd Harvey Harrison
2008-11-07 20:10                         ` reinette chatre
2008-11-07 18:03                     ` [PATCH 10/13] iwlwifi: move iwl_print_hex_dump to iwl-debug.h Harvey Harrison
2008-11-08 19:11                       ` Tomas Winkler
2008-11-07 18:07                   ` [PATCH 09/13] iwl3945 : Fix Sparse Warnings Harvey Harrison
2008-11-07 18:18                     ` reinette chatre
2008-11-08  5:51           ` Marcel Holtmann [this message]
2008-11-11 16:54             ` [PATCH 05/13] iwlwifi: update iwl-commands.h for 3 stream support reinette chatre
2008-11-07 20:58   ` [PATCH 01/13] iwlagn: fix resume for ADHOC network Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491528F5.3070408@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=daniel.c.halperin@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).