linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] orinoco: fix last beacon reporting on 64-bit systems
@ 2008-11-10 14:25 Pavel Roskin
  2008-11-12  0:48 ` Dave
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Roskin @ 2008-11-10 14:25 UTC (permalink / raw)
  To: John W Linville, linux-wireless

orinoco_translate_scan() and orinoco_translate_ext_scan() wrongly
truncate last_scanned argument from unsigned long to unsigned int.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 drivers/net/wireless/orinoco/orinoco.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/orinoco/orinoco.c b/drivers/net/wireless/orinoco/orinoco.c
index 12059f4..da5ba5e 100644
--- a/drivers/net/wireless/orinoco/orinoco.c
+++ b/drivers/net/wireless/orinoco/orinoco.c
@@ -5448,7 +5448,7 @@ static inline char *orinoco_translate_scan(struct net_device *dev,
 					   char *current_ev,
 					   char *end_buf,
 					   union hermes_scan_info *bss,
-					   unsigned int last_scanned)
+					   unsigned long last_scanned)
 {
 	struct orinoco_private *priv = netdev_priv(dev);
 	u16			capabilities;
@@ -5595,7 +5595,7 @@ static inline char *orinoco_translate_ext_scan(struct net_device *dev,
 					       char *current_ev,
 					       char *end_buf,
 					       struct agere_ext_scan_info *bss,
-					       unsigned int last_scanned)
+					       unsigned long last_scanned)
 {
 	u16			capabilities;
 	u16			channel;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] orinoco: fix last beacon reporting on 64-bit systems
  2008-11-10 14:25 [PATCH] orinoco: fix last beacon reporting on 64-bit systems Pavel Roskin
@ 2008-11-12  0:48 ` Dave
  0 siblings, 0 replies; 2+ messages in thread
From: Dave @ 2008-11-12  0:48 UTC (permalink / raw)
  To: Pavel Roskin; +Cc: John W Linville, linux-wireless

Pavel Roskin wrote:
> orinoco_translate_scan() and orinoco_translate_ext_scan() wrongly
> truncate last_scanned argument from unsigned long to unsigned int.
> 
> Signed-off-by: Pavel Roskin <proski@gnu.org>

Well spotted. IIRC that was the one of the issues you noticed with scan
output when testing my WPA patch series.

ACK from me, if it matters.


Dave.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-12  0:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-10 14:25 [PATCH] orinoco: fix last beacon reporting on 64-bit systems Pavel Roskin
2008-11-12  0:48 ` Dave

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).