linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave <kilroyd@googlemail.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Dave <kilroyd@googlemail.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Andrey Borzenkov <arvidjaar@mail.ru>,
	orinoco-devel@lists.sourceforge.net,
	linux-wireless@vger.kernel.org
Subject: Re: [Orinoco-devel] Agere PCMCIA sometimes takes very long time to associate with 9.48 FW
Date: Mon, 17 Nov 2008 19:37:27 +0000	[thread overview]
Message-ID: <4921C7F7.9000501@gmail.com> (raw)
In-Reply-To: <1226937010.10028.28.camel@localhost.localdomain>

Dan Williams wrote:
> On Sun, 2008-11-16 at 10:01 +0000, Dave wrote:
>> 2. Does the driver need to send a dissociation event (or something) to
>> userspace on ifconfig down?
> 
> If the association with the AP is no longer valid, then yes.  Most of
> the other drivers do this already, I think.

I couldn't find in in mac80211, but a few (but not all) of the fullmac
drivers seem to do it.

Andrey: the attached patch may help, but given what you've written in
your other email (which I'll respond to separately), I don't think it
will fix things. Note that it's against wireless testing (+ private
changes). Should apply cleanly to an older tree after you account for
the file move.


Regards,

Dave.
---
diff --git a/drivers/net/wireless/orinoco/orinoco.c
b/drivers/net/wireless/orinoco/orinoco.c
index f8db026..007d5b8 100644
--- a/drivers/net/wireless/orinoco/orinoco.c
+++ b/drivers/net/wireless/orinoco/orinoco.c
@@ -2319,7 +2319,21 @@ int __orinoco_down(struct net_device *dev)
                hermes_set_irqmask(hw, 0);
                hermes_write_regn(hw, EVACK, 0xffff);
        }
-
+
+       /* If associated, tell userspace we're dropping it */
+       if ((priv->last_linkstatus == HERMES_LINKSTATUS_CONNECTED) ||
+           (priv->last_linkstatus == HERMES_LINKSTATUS_AP_CHANGE) ||
+           (priv->last_linkstatus == HERMES_LINKSTATUS_AP_IN_RANGE))
+       {
+               union iwreq_data wrqu;
+
+               wrqu.data.length = 0;
+               wrqu.data.flags = 0;
+               wrqu.ap_addr.sa_family = ARPHRD_ETHER;
+               memset(wrqu.ap_addr.sa_data, 0, ETH_ALEN);
+               wireless_send_event(dev, SIOCGIWAP, &wrqu, NULL);
+       }
+
        /* firmware will have to reassociate */
        netif_carrier_off(dev);
        priv->last_linkstatus = 0xffff;


  reply	other threads:[~2008-11-17 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200810191436.13298.arvidjaar@mail.ru>
     [not found] ` <491349BC.8090606@gmail.com>
     [not found]   ` <49134F66.4020608@gmail.com>
2008-11-15  8:15     ` [Orinoco-devel] Agere PCMCIA sometimes takes very long time to associate with 9.48 FW Andrey Borzenkov
2008-11-15 14:56       ` John W. Linville
2008-11-16 10:01         ` Dave
2008-11-17 15:50           ` Dan Williams
2008-11-17 19:37             ` Dave [this message]
2008-11-17 19:29           ` Andrey Borzenkov
2008-11-17 20:37             ` Dave
2008-11-22  7:56               ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4921C7F7.9000501@gmail.com \
    --to=kilroyd@googlemail.com \
    --cc=arvidjaar@mail.ru \
    --cc=dcbw@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=orinoco-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).