From: Marcel Holtmann <holtmann@linux.intel.com>
To: linux-wireless@vger.kernel.org
Subject: iwlwifi produces "Can not allocate SKB buffers"
Date: Fri, 21 Nov 2008 16:04:15 +0100 [thread overview]
Message-ID: <4926CDEF.4090908@linux.intel.com> (raw)
Hi guys,
after the DMA issues got fixed, I am still seeing the SKB allocation
errors. So I put a WARN() into the code:
diff --git a/drivers/net/wireless/iwlwifi/iwl-rx.c
b/drivers/net/wireless/iwlwifi/iwl-rx.c
index 8d2b73e..acd9b12 100644
--- a/drivers/net/wireless/iwlwifi/iwl-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
@@ -252,10 +252,7 @@ void iwl_rx_allocate(struct iwl_priv *priv)
/* Alloc a new receive buffer */
rxb->skb = alloc_skb(priv->hw_params.rx_buf_size + 256,
__GFP_NOWARN | GFP_ATOMIC);
- if (!rxb->skb) {
- if (net_ratelimit())
- printk(KERN_CRIT DRV_NAME
- ": Can not allocate SKB buffers\n");
+ if (WARN(!rxb->skb, "Can not allocate SKB buffers\n")) {
/* We don't reschedule replenish work here -- we
will
* call the restock method and if it still needs
* more buffers it will schedule replenish */
This allows me to record these issue via kerneloops.org. And here is one
from my current wireless-testing tree I am running:
http://www.kerneloops.org/raw.php?rawid=104543&msgid=
Regards
Marcel
reply other threads:[~2008-11-21 14:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4926CDEF.4090908@linux.intel.com \
--to=holtmann@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).