From: pat-lkml <pat-lkml@erley.org>
To: Jouni Malinen <j@w1.fi>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: Free Beacon skbs in AP mode
Date: Fri, 05 Dec 2008 22:07:47 -0500 [thread overview]
Message-ID: <4939EC83.4060908@erley.org> (raw)
In-Reply-To: <20081205184245.GA10596@jm.kir.nu>
Jouni Malinen wrote:
> Fix a memory leak where AP mode did not free transmitted Beacon frame
> skbs.
>
> Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
>
> Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:37:37.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:38:41.000000000 +0200
> @@ -167,6 +167,7 @@
> pci_unmap_single(sc->pdev, bf->bf_dmacontext,
> skb->len,
> PCI_DMA_TODEVICE);
> + dev_kfree_skb_any(skb);
> }
>
> skb = ieee80211_beacon_get(sc->hw, vif);
>
Acked-by: Pat Erley <pat-lkml@erley.org>
I've been using ath9k in master mode for a few weeks and
had noticed a severe memory leak (kill a gig of ram system in about a
day). Figured it was just in hostapd, and haven't had time to track it
down.
prev parent reply other threads:[~2008-12-06 3:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 18:42 [PATCH] ath9k: Free Beacon skbs in AP mode Jouni Malinen
2008-12-06 3:07 ` pat-lkml [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4939EC83.4060908@erley.org \
--to=pat-lkml@erley.org \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).