* [PATCH] ath9k: Free Beacon skbs in AP mode
@ 2008-12-05 18:42 Jouni Malinen
2008-12-06 3:07 ` pat-lkml
0 siblings, 1 reply; 2+ messages in thread
From: Jouni Malinen @ 2008-12-05 18:42 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, ath9k-devel
Fix a memory leak where AP mode did not free transmitted Beacon frame
skbs.
Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:37:37.000000000 +0200
+++ wireless-testing/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:38:41.000000000 +0200
@@ -167,6 +167,7 @@
pci_unmap_single(sc->pdev, bf->bf_dmacontext,
skb->len,
PCI_DMA_TODEVICE);
+ dev_kfree_skb_any(skb);
}
skb = ieee80211_beacon_get(sc->hw, vif);
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ath9k: Free Beacon skbs in AP mode
2008-12-05 18:42 [PATCH] ath9k: Free Beacon skbs in AP mode Jouni Malinen
@ 2008-12-06 3:07 ` pat-lkml
0 siblings, 0 replies; 2+ messages in thread
From: pat-lkml @ 2008-12-06 3:07 UTC (permalink / raw)
To: Jouni Malinen; +Cc: linux-wireless, ath9k-devel
Jouni Malinen wrote:
> Fix a memory leak where AP mode did not free transmitted Beacon frame
> skbs.
>
> Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
>
> Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:37:37.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:38:41.000000000 +0200
> @@ -167,6 +167,7 @@
> pci_unmap_single(sc->pdev, bf->bf_dmacontext,
> skb->len,
> PCI_DMA_TODEVICE);
> + dev_kfree_skb_any(skb);
> }
>
> skb = ieee80211_beacon_get(sc->hw, vif);
>
Acked-by: Pat Erley <pat-lkml@erley.org>
I've been using ath9k in master mode for a few weeks and
had noticed a severe memory leak (kill a gig of ram system in about a
day). Figured it was just in hostapd, and haven't had time to track it
down.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-06 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-05 18:42 [PATCH] ath9k: Free Beacon skbs in AP mode Jouni Malinen
2008-12-06 3:07 ` pat-lkml
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).