From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christian Lamparter <chunkeey@web.de>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 2/2] p54: enforce strict tx_queue limits
Date: Tue, 09 Dec 2008 20:39:00 -0600 [thread overview]
Message-ID: <493F2BC4.7040201@lwfinger.net> (raw)
In-Reply-To: <200812092109.00988.chunkeey@web.de>
Christian Lamparter wrote:
> The patch fixes an old FIXME in p54pci.c by moving the "queue full"
> check into the common library, where we can deal with it properly.
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> ---
> diff -Nurp a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
> --- a/drivers/net/wireless/p54/p54common.c 2008-12-09 20:13:56.467888032 +0100
> +++ b/drivers/net/wireless/p54/p54common.c 2008-12-09 20:49:21.235888230 +0100
> @@ -889,7 +889,27 @@ static int p54_assign_address(struct iee
> return -EINVAL;
>
> spin_lock_irqsave(&priv->tx_queue.lock, flags);
> +
> left = skb_queue_len(&priv->tx_queue);
> + if (unlikely(left >= 28)) {
> + /*
> + * The tx_queue is nearly full!
> + * We have throttle normal data traffic, because we must
> + * have a few spare slots for control frames left.
> + */
> + ieee80211_stop_queues(dev);
I do not intend this as a criticism of the patch, but how do the queues get
restarted after this?
Larry
next prev parent reply other threads:[~2008-12-10 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 20:09 [PATCH 2/2] p54: enforce strict tx_queue limits Christian Lamparter
2008-12-10 2:39 ` Larry Finger [this message]
2008-12-10 11:54 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493F2BC4.7040201@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).