From: Patrick McHardy <kaber@trash.net>
To: linux-wireless@vger.kernel.org
Cc: Jiri Slaby <jirislaby@gmail.com>,
mickflemm@gmail.com, mcgrof@gmail.com, me@bobcopeland.com
Subject: [RFC]: ath5k: enable TXOK IRQ
Date: Wed, 10 Dec 2008 06:13:52 +0100 [thread overview]
Message-ID: <493F5010.7030500@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
I tried to use ath5k in AP mode with hostapd, but hostapd never
added the authenticated and associated stations to the kernel.
The reason is that ath5k didn't invoke the tx tasklet, so it
did not call the ieee80211_tx_status() function and userspace
didn't receive the radiotap message indicating success.
The root cause appears to be that the TXOK interrupt is not
enabled, so the tasklet is never scheduled. I'm not sure whether
TXOK is really the correct one to handle ! IEEE80211_TX_CTL_NO_ACK,
but it fixes the problem for me.
[-- Attachment #2: 02.diff --]
[-- Type: text/x-patch, Size: 980 bytes --]
commit 5ecbb104a7202a6ed9bcfa8b8ef46474d1003600
Author: Patrick McHardy <kaber@trash.net>
Date: Tue Dec 9 21:54:51 2008 +0100
ath5k: enable TXOK IRQ
Without the IRQ, the tx tasklet is not scheduled, which is necessary
to invoke ieee80211_tx_status() to notify userspace of successfully
sent frames.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index 940c724..291a334 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -1348,7 +1348,8 @@ ath5k_txq_setup(struct ath5k_softc *sc,
* up in which case the top half of the kernel may backup
* due to a lack of tx descriptors.
*/
- qi.tqi_flags = AR5K_TXQ_FLAG_TXEOLINT_ENABLE |
+ qi.tqi_flags = AR5K_TXQ_FLAG_TXOKINT_ENABLE |
+ AR5K_TXQ_FLAG_TXEOLINT_ENABLE |
AR5K_TXQ_FLAG_TXDESCINT_ENABLE;
qnum = ath5k_hw_setup_tx_queue(ah, qtype, &qi);
if (qnum < 0) {
next reply other threads:[~2008-12-10 5:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 5:13 Patrick McHardy [this message]
2008-12-17 15:38 ` [RFC]: ath5k: enable TXOK IRQ John W. Linville
2008-12-17 16:52 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493F5010.7030500@trash.net \
--to=kaber@trash.net \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).