p54usb problems

[Larry Finger <Larry.Finger@lwfinger.net>]

Christian,

As you may have seen, one of my failed p54usb runs hit a WARN_ON in mac80211 due
to a faulty pkt_type in the skb. Johannes thinks this is most likely caused by
memory corruption. When I looked at the RX callback, I don't see any locking. Is
that correct?

On a different run, I had a failure to allocate a new skb because there was not
a free memory chunk of order(1). When I hit that, I remembered your suggestion
for reducing rx_mtu to keep the skb of order(0). What is your reaction to the
following patch? On my x86_64 system, the message that prints is "p54:
Calculated rx_mtu of 3240 reduced to 2356".

I have not hit the frame control patch you sent, at least not yet.

Larry


Index: wireless-testing/drivers/net/wireless/p54/p54common.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/p54/p54common.c
+++ wireless-testing/drivers/net/wireless/p54/p54common.c
@@ -195,6 +195,11 @@ int p54_parse_firmware(struct ieee80211_
 			else
 				priv->rx_mtu = (size_t)
 					0x620 - priv->tx_hdr_len;
+			if (priv->rx_mtu > 2356 && PAGE_SIZE == 4096) {
+				printk(KERN_INFO "p54: Calculated rx_mtu of %d"
+				       " reduced to 2356\n", priv->rx_mtu);
+				priv->rx_mtu = 2356;
+			}
 			break;
 			}
 		case BR_CODE_EXPOSED_IF: