Re: Mesh now completely broken on ath5k, latest git

[Steve Brown <sbrown@cortland.com>]

Keir wrote:
> Tried this, and I'm getting slightly odd results.  The two nodes
> running with these lines commented out can see the node whose code is
> previous to the PCU patch, but they cant see each other.  Also the
> other node can see both of them... very strange.
>
> Cheers
>
> Keir
>
> 2008/12/17 Nick Kossifidis <mickflemm@gmail.com>:
>   
>> 2008/12/16 Andrey Yurovsky <andrey@cozybit.com>:
>>     
>>> Hi Keir.  What type of Atheros-based card are you using?  How many
>>> antennas do you have connected?  If I understand things correctly, the
>>> PCU code regression (with respect to mesh and maybe AP and IBSS) has
>>> to do with having one antenna hooked up when your hardware also has an
>>> AUX antenna connector.  If you have only one antenna, can you please
>>> plug in a second one and try again (before and after the commit in
>>> question)?  I will try to do the same test here.  More details from
>>> Nick were posted here:
>>> http://marc.info/?l=linux-wireless&m=122771338021489&w=2
>>>
>>>       
>> To summarize, the following code on base.c is the problem...
>>
>> 1955                 /*
>> 1956                  * Switch antenna every 4 beacons if txantenna is not set
>> 1957                  * XXX assumes two antennas
>> 1958                  */
>> 1959                 if (antenna == 0)
>> 1960                         antenna = sc->bsent & 4 ? 2 : 1;
>>
>> ...we should always set 0 on tx descriptor for the default scenario to
>> work. Can you please comment this out and see if it works ?
>>
>> --
>> GPG ID: 0xD21DB2DB
>> As you read this post global entropy rises. Have Fun ;-)
>> Nick
>>
>>     
I did a binary chop on the pcu patch. Reverting this part of the patch 
restores ap and mesh beaconing. I've no idea why.

77: +               else
78: +                       AR5K_REG_ENABLE_BITS(ah, AR5K_CFG, 
AR5K_CFG_ADHOC);

Steve