From: Felix Fietkau <nbd@openwrt.org>
To: Christian Lamparter <chunkeey@web.de>
Cc: wireless <linux-wireless@vger.kernel.org>,
John W Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] minstrel: fix warning if lowest supported rate index is not 0
Date: Mon, 22 Dec 2008 16:11:33 +0100 [thread overview]
Message-ID: <494FAE25.6000401@openwrt.org> (raw)
In-Reply-To: <200812221535.32032.chunkeey@web.de>
Christian Lamparter wrote:
> This patch fixes the following WARNING (caused by rix_to_ndx): "
>>WARNING: at net/mac80211/rc80211_minstrel.c:69 minstrel_rate_init+0xd2/0x33a [mac80211]()
>>[...]
>>Call Trace:
>> warn_on_slowpath+0x51/0x75
>> _format_mac_addr+0x4c/0x88
>> minstrel_rate_init+0xd2/0x33a [mac80211]
>> print_mac+0x16/0x1b
>> schedule_hrtimeout_range+0xdc/0x107
>> ieee80211_add_station+0x158/0x1bd [mac80211]
>> nl80211_new_station+0x1b3/0x20b [cfg80211]
>
> The reason is that I'm experimenting with "g" only mode on a 802.11 b/g card.
>
> Therefore rate_lowest_index returns 4 (= 6Mbit, instead of usual 0 = 1Mbit).
> Since mi->r array is initialized with zeros in minstrel_alloc_sta,
> rix_to_ndx has a hard time to find the 6Mbit entry and will trigged the WARNING.
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
Acked-by: Felix Fietkau <nbd@openwrt.org>
prev parent reply other threads:[~2008-12-22 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 14:35 [PATCH] minstrel: fix warning if lowest supported rate index is not 0 Christian Lamparter
2008-12-22 15:11 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494FAE25.6000401@openwrt.org \
--to=nbd@openwrt.org \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).