* [PATCH 1/1] IWL: fix WARN typo
@ 2009-01-05 16:03 Jiri Slaby
2009-01-05 16:04 ` Jiri Slaby
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jiri Slaby @ 2009-01-05 16:03 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, linux-kernel, Jiri Slaby, Tomas Winkler
new kew -> a new key
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Tomas Winkler <tomas.winkler@intel.com>
Cc: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/iwlwifi/iwl-sta.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
index 412f66b..b28564a 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
@@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv,
* in uCode. */
WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
- "no space for new kew");
+ "no space for a new key");
priv->stations[sta_id].sta.key.key_flags = key_flags;
priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK;
--
1.6.0.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] IWL: fix WARN typo 2009-01-05 16:03 [PATCH 1/1] IWL: fix WARN typo Jiri Slaby @ 2009-01-05 16:04 ` Jiri Slaby 2009-01-05 16:06 ` [PATCH 1/1 #2] " Jiri Slaby 2009-01-05 19:02 ` [PATCH 1/1] " Johannes Berg 2 siblings, 0 replies; 7+ messages in thread From: Jiri Slaby @ 2009-01-05 16:04 UTC (permalink / raw) To: linville; +Cc: linux-wireless, linux-kernel, Tomas Winkler On 01/05/2009 05:03 PM, Jiri Slaby wrote: > new kew -> a new key ... > - "no space for new kew"); > + "no space for a new key"); There are more of them, hold on, I'll post an updated one. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1 #2] IWL: fix WARN typo 2009-01-05 16:03 [PATCH 1/1] IWL: fix WARN typo Jiri Slaby 2009-01-05 16:04 ` Jiri Slaby @ 2009-01-05 16:06 ` Jiri Slaby 2009-01-09 20:18 ` John W. Linville 2009-01-05 19:02 ` [PATCH 1/1] " Johannes Berg 2 siblings, 1 reply; 7+ messages in thread From: Jiri Slaby @ 2009-01-05 16:06 UTC (permalink / raw) To: linville; +Cc: linux-wireless, linux-kernel, Jiri Slaby, Tomas Winkler new kew -> a new key Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Cc: Tomas Winkler <tomas.winkler@intel.com> Cc: John W. Linville <linville@tuxdriver.com> --- drivers/net/wireless/iwlwifi/iwl-sta.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c index 412f66b..ce2ba40 100644 --- a/drivers/net/wireless/iwlwifi/iwl-sta.c +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv, * in uCode. */ WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, - "no space for new kew"); + "no space for a new key"); priv->stations[sta_id].sta.key.key_flags = key_flags; priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; @@ -686,7 +686,7 @@ static int iwl_set_ccmp_dynamic_key_info(struct iwl_priv *priv, * in uCode. */ WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, - "no space for new kew"); + "no space for a new key"); priv->stations[sta_id].sta.key.key_flags = key_flags; priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; @@ -722,7 +722,7 @@ static int iwl_set_tkip_dynamic_key_info(struct iwl_priv *priv, * in uCode. */ WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, - "no space for new kew"); + "no space for a new key"); /* This copy is acutally not needed: we get the key with each TX */ memcpy(priv->stations[sta_id].keyinfo.key, keyconf->key, 16); -- 1.6.0.6 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1 #2] IWL: fix WARN typo 2009-01-05 16:06 ` [PATCH 1/1 #2] " Jiri Slaby @ 2009-01-09 20:18 ` John W. Linville 2009-01-09 21:42 ` John W. Linville 0 siblings, 1 reply; 7+ messages in thread From: John W. Linville @ 2009-01-09 20:18 UTC (permalink / raw) To: Jiri Slaby; +Cc: linux-wireless, linux-kernel, Tomas Winkler Is the way it is now problematic for non-native English speakers? Or native ones for that matter? Dropping an article in a "computer-ese" statement has never bothered me, so this seems like just a handful of unnecessary string bytes? John On Mon, Jan 05, 2009 at 05:06:06PM +0100, Jiri Slaby wrote: > new kew -> a new key > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > Cc: Tomas Winkler <tomas.winkler@intel.com> > Cc: John W. Linville <linville@tuxdriver.com> > --- > drivers/net/wireless/iwlwifi/iwl-sta.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c > index 412f66b..ce2ba40 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c > @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv, > * in uCode. */ > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > - "no space for new kew"); > + "no space for a new key"); > > priv->stations[sta_id].sta.key.key_flags = key_flags; > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; > @@ -686,7 +686,7 @@ static int iwl_set_ccmp_dynamic_key_info(struct iwl_priv *priv, > * in uCode. */ > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > - "no space for new kew"); > + "no space for a new key"); > > priv->stations[sta_id].sta.key.key_flags = key_flags; > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; > @@ -722,7 +722,7 @@ static int iwl_set_tkip_dynamic_key_info(struct iwl_priv *priv, > * in uCode. */ > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > - "no space for new kew"); > + "no space for a new key"); > > /* This copy is acutally not needed: we get the key with each TX */ > memcpy(priv->stations[sta_id].keyinfo.key, keyconf->key, 16); > -- > 1.6.0.6 > > -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1 #2] IWL: fix WARN typo 2009-01-09 20:18 ` John W. Linville @ 2009-01-09 21:42 ` John W. Linville 2009-01-09 22:20 ` Johannes Berg 0 siblings, 1 reply; 7+ messages in thread From: John W. Linville @ 2009-01-09 21:42 UTC (permalink / raw) To: Jiri Slaby; +Cc: linux-wireless, linux-kernel, Tomas Winkler People have pointed-out the "kew -> key" part of the patch. Any thoughts on "new key" vs. "a new key"? John On Fri, Jan 09, 2009 at 03:18:00PM -0500, John W. Linville wrote: > Is the way it is now problematic for non-native English speakers? > Or native ones for that matter? > > Dropping an article in a "computer-ese" statement has never bothered > me, so this seems like just a handful of unnecessary string bytes? > > John > > On Mon, Jan 05, 2009 at 05:06:06PM +0100, Jiri Slaby wrote: > > new kew -> a new key > > > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > Cc: Tomas Winkler <tomas.winkler@intel.com> > > Cc: John W. Linville <linville@tuxdriver.com> > > --- > > drivers/net/wireless/iwlwifi/iwl-sta.c | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c > > index 412f66b..ce2ba40 100644 > > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c > > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c > > @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv, > > * in uCode. */ > > > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > > - "no space for new kew"); > > + "no space for a new key"); > > > > priv->stations[sta_id].sta.key.key_flags = key_flags; > > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; > > @@ -686,7 +686,7 @@ static int iwl_set_ccmp_dynamic_key_info(struct iwl_priv *priv, > > * in uCode. */ > > > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > > - "no space for new kew"); > > + "no space for a new key"); > > > > priv->stations[sta_id].sta.key.key_flags = key_flags; > > priv->stations[sta_id].sta.sta.modify_mask = STA_MODIFY_KEY_MASK; > > @@ -722,7 +722,7 @@ static int iwl_set_tkip_dynamic_key_info(struct iwl_priv *priv, > > * in uCode. */ > > > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > > - "no space for new kew"); > > + "no space for a new key"); > > > > /* This copy is acutally not needed: we get the key with each TX */ > > memcpy(priv->stations[sta_id].keyinfo.key, keyconf->key, 16); > > -- > > 1.6.0.6 > > > > > > -- > John W. Linville Linux should be at the core > linville@tuxdriver.com of your literate lifestyle. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1 #2] IWL: fix WARN typo 2009-01-09 21:42 ` John W. Linville @ 2009-01-09 22:20 ` Johannes Berg 0 siblings, 0 replies; 7+ messages in thread From: Johannes Berg @ 2009-01-09 22:20 UTC (permalink / raw) To: John W. Linville; +Cc: Jiri Slaby, linux-wireless, linux-kernel, Tomas Winkler [-- Attachment #1: Type: text/plain, Size: 241 bytes --] On Fri, 2009-01-09 at 16:42 -0500, John W. Linville wrote: > People have pointed-out the "kew -> key" part of the patch. > Any thoughts on "new key" vs. "a new key"? As I said, if anything it should be "the", not "a" imho. johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] IWL: fix WARN typo 2009-01-05 16:03 [PATCH 1/1] IWL: fix WARN typo Jiri Slaby 2009-01-05 16:04 ` Jiri Slaby 2009-01-05 16:06 ` [PATCH 1/1 #2] " Jiri Slaby @ 2009-01-05 19:02 ` Johannes Berg 2 siblings, 0 replies; 7+ messages in thread From: Johannes Berg @ 2009-01-05 19:02 UTC (permalink / raw) To: Jiri Slaby; +Cc: linville, linux-wireless, linux-kernel, Tomas Winkler [-- Attachment #1: Type: text/plain, Size: 886 bytes --] On Mon, 2009-01-05 at 17:03 +0100, Jiri Slaby wrote: > new kew -> a new key > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > Cc: Tomas Winkler <tomas.winkler@intel.com> > Cc: John W. Linville <linville@tuxdriver.com> > --- > drivers/net/wireless/iwlwifi/iwl-sta.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c > index 412f66b..b28564a 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c > @@ -638,7 +638,7 @@ static int iwl_set_wep_dynamic_key_info(struct iwl_priv *priv, > * in uCode. */ > > WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET, > - "no space for new kew"); > + "no space for a new key"); Eh, if anything shouldn't that be "the new key"? johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-01-09 22:19 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-01-05 16:03 [PATCH 1/1] IWL: fix WARN typo Jiri Slaby 2009-01-05 16:04 ` Jiri Slaby 2009-01-05 16:06 ` [PATCH 1/1 #2] " Jiri Slaby 2009-01-09 20:18 ` John W. Linville 2009-01-09 21:42 ` John W. Linville 2009-01-09 22:20 ` Johannes Berg 2009-01-05 19:02 ` [PATCH 1/1] " Johannes Berg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).