From: Dave <kilroyd@googlemail.com>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: orinoco-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.28: warn_slowpath in orinoco receive path
Date: Tue, 06 Jan 2009 23:40:00 +0000 [thread overview]
Message-ID: <4963EBD0.2080907@gmail.com> (raw)
In-Reply-To: <200901070007.52508.arvidjaar@mail.ru>
Andrey Borzenkov wrote:
> On 06 January 2009 23:02:06 Dave wrote:
>
>> Since we have to use spinlock we should introduce an rx_lock
>> specifically to protect the list so the tasklet is not held up by
>> anything else the driver is doing. I'll put something together if you
>> don't get round to it first.
>>
>
> You mean something like attached patch? Not sure if it worth it frankly.
That's what I meant. I forgot we took orinoco_lock in orinoco_interrupt
though, and that highlights the fact that I've neglected to ensure
orinoco_lock is held when orinoco_rx is called from the tasklet.
So the locking gets simpler and fixes more problems than the one you
noticed. But there's some extra cleanup to do. I'll submit a patch in a
second.
I'm surprised my wireless hasn't misbehaved in the last year.
Dave.
next prev parent reply other threads:[~2009-01-06 23:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 17:05 2.6.28: warn_slowpath in orinoco receive path Andrey Borzenkov
2009-01-05 20:32 ` Dave
2009-01-05 22:27 ` Jiri Slaby
2009-01-06 0:32 ` Robert Hancock
2009-01-06 9:51 ` Andrey Borzenkov
2009-01-06 20:02 ` Dave
2009-01-06 21:07 ` Andrey Borzenkov
2009-01-06 23:40 ` Dave [this message]
2009-01-07 2:42 ` [Orinoco-devel] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4963EBD0.2080907@gmail.com \
--to=kilroyd@googlemail.com \
--cc=arvidjaar@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).