From: Gabor Juhos <juhosg@openwrt.org>
To: Pavel Roskin <proski@gnu.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jouni Malinen <jmalinen@atheros.com>,
Christoph Hellwig <hch@infradead.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [ath9k-devel] [PATCH v2 08/11] ath9k: remove (u16) casts from rtc register access
Date: Fri, 09 Jan 2009 21:40:12 +0100 [thread overview]
Message-ID: <4967B62C.1050203@openwrt.org> (raw)
In-Reply-To: <1231519108.24032.1.camel@dv>
Pavel Roskin =EDrta:
> On Fri, 2009-01-09 at 13:24 +0100, Gabor Juhos wrote:
>> The RTC register offsets don't fit into 'u16' on the AR913x, so we h=
ave
>> to remove the existing casts.
>>
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
>> ---
>> drivers/net/wireless/ath9k/hw.c | 14 +++++++-------
>> 1 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/=
ath9k/hw.c
>> index 088d968..742ecc1 100644
>> --- a/drivers/net/wireless/ath9k/hw.c
>> +++ b/drivers/net/wireless/ath9k/hw.c
>> @@ -1008,7 +1008,7 @@ static void ath9k_hw_init_pll(struct ath_hal *=
ah,
>> pll |=3D SM(0xb, AR_RTC_PLL_DIV);
>> }
>> }
>> - REG_WRITE(ah, (u16) (AR_RTC_PLL_CONTROL), pll);
>> + REG_WRITE(ah, (AR_RTC_PLL_CONTROL), pll);
>=20
> Perhaps you could remove the parentheses as well? It looks weird
> otherwise.
>=20
Yes. I will do it.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-09 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 12:24 [PATCH v2 00/11] ath9k: add preliminary support for the AR913x SoCs Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 01/11] ath9k: convert to struct device Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 02/11] ath9k: convert to use bus-agnostic DMA routines Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 03/11] ath9k: introduce bus specific cache size routine Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 04/11] ath9k: introduce bus specific cleanup routine Gabor Juhos
2009-01-09 12:33 ` Johannes Berg
2009-01-09 12:44 ` Johannes Berg
2009-01-09 12:24 ` [PATCH v2 05/11] ath9k: move PCI code into separate file Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 06/11] ath9k: introduce platform driver for AHB bus support Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 07/11] ath9k: get EEPROM contents from platform data on AHB bus Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 08/11] ath9k: remove (u16) casts from rtc register access Gabor Juhos
2009-01-09 16:38 ` [ath9k-devel] " Pavel Roskin
2009-01-09 20:40 ` Gabor Juhos [this message]
2009-01-09 12:24 ` [PATCH v2 09/11] ath9k: fix ar5416Addac_9100 values Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 10/11] ath9k: fix null pointer dereference in ani monitor code Gabor Juhos
2009-01-09 12:24 ` [PATCH v2 11/11] ath9k: enable support for AR9100 Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4967B62C.1050203@openwrt.org \
--to=juhosg@openwrt.org \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=hch@infradead.org \
--cc=jmalinen@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).