* Warning in latest wireless-testing @ 2009-01-13 23:59 Larry Finger 2009-01-14 0:06 ` Johannes Berg 0 siblings, 1 reply; 3+ messages in thread From: Larry Finger @ 2009-01-13 23:59 UTC (permalink / raw) To: John Linville, Michael Buesch; +Cc: wireless In the latest pull from wireless testing, I get the following warning: CC [M] drivers/net/wireless/b43/main.o drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_set_key=E2= =80=99: drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatch in conditional expression Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Warning in latest wireless-testing 2009-01-13 23:59 Warning in latest wireless-testing Larry Finger @ 2009-01-14 0:06 ` Johannes Berg 2009-01-14 13:33 ` John W. Linville 0 siblings, 1 reply; 3+ messages in thread From: Johannes Berg @ 2009-01-14 0:06 UTC (permalink / raw) To: Larry Finger; +Cc: John Linville, Michael Buesch, wireless [-- Attachment #1: Type: text/plain, Size: 750 bytes --] On Tue, 2009-01-13 at 17:59 -0600, Larry Finger wrote: > In the latest pull from wireless testing, I get the following warning: > > CC [M] drivers/net/wireless/b43/main.o > drivers/net/wireless/b43/main.c: In function ‘b43_op_set_key’: > drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatch > in conditional expression That looks like a merge error: b43dbg(wl, "%s hardware based encryption for keyidx: %d, " "mac: %pM\n", cmd == SET_KEY ? "Using" : "Disabling", key->keyidx, sta ? sta->addr : "<group key>"); It should be something like u8 bcast[ETH_ALEN] = {0xff,...} sta ? sta->addr : bcast there. johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Warning in latest wireless-testing 2009-01-14 0:06 ` Johannes Berg @ 2009-01-14 13:33 ` John W. Linville 0 siblings, 0 replies; 3+ messages in thread From: John W. Linville @ 2009-01-14 13:33 UTC (permalink / raw) To: Johannes Berg; +Cc: Larry Finger, Michael Buesch, wireless On Wed, Jan 14, 2009 at 01:06:10AM +0100, Johannes Berg wrote: > On Tue, 2009-01-13 at 17:59 -0600, Larry Finger wrote: > > In the latest pull from wireless testing, I get the following warni= ng: > >=20 > > CC [M] drivers/net/wireless/b43/main.o > > drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_set_ke= y=E2=80=99: > > drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatc= h > > in conditional expression >=20 > That looks like a merge error: Yes, it is. > b43dbg(wl, "%s hardware based encryption for keyidx: = %d, " > "mac: %pM\n", > cmd =3D=3D SET_KEY ? "Using" : "Disabling", ke= y->keyidx, > sta ? sta->addr : "<group key>"); >=20 > It should be something like >=20 > u8 bcast[ETH_ALEN] =3D {0xff,...} >=20 > sta ? sta->addr : bcast >=20 > there. Yes, it should. John --=20 John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-14 13:37 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-01-13 23:59 Warning in latest wireless-testing Larry Finger 2009-01-14 0:06 ` Johannes Berg 2009-01-14 13:33 ` John W. Linville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).