From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Eliminate compilation warning in b43_op_set_key
Date: Wed, 14 Jan 2009 09:47:09 -0600 [thread overview]
Message-ID: <496E08FD.9030803@lwfinger.net> (raw)
In-Reply-To: <20090114133417.GB18634@tuxdriver.com>
John W. Linville wrote:
> On Tue, Jan 13, 2009 at 06:20:25PM -0600, Larry Finger wrote:
>> A recent pull from wireless testing generates the following warning:
>> =20
>> CC [M] drivers/net/wireless/b43/main.o
>> drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_set_ke=
y=E2=80=99:
>> drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatc=
h
>> in conditional expression
>>
>> This fix was suggested by Johannes Berg <johannes@sipsolutions.net>.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>>
>> Index: wireless-testing/drivers/net/wireless/b43/main.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
>> +++ wireless-testing/drivers/net/wireless/b43/main.c
>> @@ -3630,10 +3630,12 @@ static int b43_op_set_key(struct ieee802
>> =20
>> out_unlock:
>> if (!err) {
>> + u8 bcast[ETH_ALEN];
>> + memset(bcast, 0xff, ETH_ALEN);
>=20
> Isn't there a statically-allocated array w/ the broadcast MAC in it
> somewhere already?
>=20
Not that I could find.
There are several places in mac80211 where the broadcast MAC is
created on the fly. None of them would benefit from having a static
array - one would just substitute memcpy for memset and possibly trash
the cache.
There is an array broadcast[MAX_ADDR_LEN] in struct net_device, but it
would need to be initialized with 0xFF's before usage.
I still think that b43 needs to create this array, and that the best
place to do it is in the error path that is unlikely to be executed.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-14 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 0:20 [PATCH] b43: Eliminate compilation warning in b43_op_set_key Larry Finger
2009-01-14 13:34 ` John W. Linville
2009-01-14 15:47 ` Larry Finger [this message]
2009-01-14 16:57 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E08FD.9030803@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).