From: Artur Skawina <art.08.09@gmail.com>
To: Christian Lamparter <chunkeey@web.de>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] p54usb: fix nasty use after free
Date: Tue, 20 Jan 2009 12:45:12 +0100 [thread overview]
Message-ID: <4975B948.2010808@gmail.com> (raw)
In-Reply-To: <200901200027.57128.chunkeey@web.de>
Christian Lamparter wrote:
> In theory, the firmware acks the received a data frame, before signaling the driver to free it again.
> However Artur Skawina <art.08.09@gmail.com> has shown that it can happen in reverse order as well.
> This is very bad and could lead to memory corruptions, oopses and panics.
>
> Thanks to Artur Skawina <art.08.09@gmail.com> for reporting and debugging this issue.
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> ---
> Anyone with a p54usb device (Especially you, Artur :-) ):
>
> Please test this!
> Because it should go to wireless-2.6 / 2.6.29 as well (John?)
good news: i've run a few tests w/ it and didn't see any memory corruption warnings,
previously i used to get them almost immediately, usually during association, now
i was able to transfer ~1M of data w/ no sign of corruption.
The large packet loss is still there and the device is still unusable (because of
the extremely low throughput, that 1M took several minutes to transfer and three
attempts to associate before it worked). But no crashes, that's a huge improvement :)
Tested-by: Artur Skawina <art.08.09@gmail.com>
artur
next prev parent reply other threads:[~2009-01-20 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 23:27 [PATCH] p54usb: fix nasty use after free Christian Lamparter
2009-01-20 11:45 ` Artur Skawina [this message]
2009-01-20 12:12 ` Artur Skawina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975B948.2010808@gmail.com \
--to=art.08.09@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).