From: Arnd Bergmann <arnd@arndb.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Eliad Peller <eliad@wizery.com>,
Yegor Yefremov <yegorslists@googlemail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
devicetree@vger.kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH] wlcore: add basic device-tree support
Date: Mon, 21 Jul 2014 22:19:28 +0200 [thread overview]
Message-ID: <4978000.DXO6RXA1rg@wuerfel> (raw)
In-Reply-To: <20140721164505.GD9026@tuxdriver.com>
On Monday 21 July 2014 12:45:05 John W. Linville wrote:
> On Wed, Jul 09, 2014 at 02:45:33PM +0300, Eliad Peller wrote:
> > On Wed, Jul 9, 2014 at 2:00 PM, Yegor Yefremov
> > <yegorslists@googlemail.com> wrote:
> > > On Wed, Jul 9, 2014 at 11:31 AM, Eliad Peller <eliad@wizery.com> wrote:
> > >> When running with device-tree, we no longer have a board file
> > >> that can set up the platform data for wlcore.
> > >> Allow this data to be passed from DT.
> > >>
> > >> For now, parse only the irq used. Other (optional) properties
> > >> can be added later on.
> > >
> > > What about adding support for "mac-address"
> > > (Documentation/devicetree/bindings/net/ethernet.txt) node or will it
> > > be automatically available?
> > >
> > the mac address is currently either read from the device itself or
> > from the nvs (calibration) file.
> > i guess additional support for such dt properties can be added later
> > on, if needed.
>
> Ok with the device tree folks?
>
Doesn't seem wrong, though it's generally best to allow overriding
the mac address from DT. It's only a one-line addition to call
of_get_mac_address().
Looking at the original patch though, I wonder if this is compatible
with the generic way that SDIO device DT properties are supposed
to work. Ulf Hansson has recently been looking into a related area,
maybe he can comment.
Arnd
prev parent reply other threads:[~2014-07-21 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 9:31 [PATCH] wlcore: add basic device-tree support Eliad Peller
2014-07-09 11:00 ` Yegor Yefremov
2014-07-09 11:45 ` Eliad Peller
2014-07-21 16:45 ` John W. Linville
2014-07-21 20:19 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4978000.DXO6RXA1rg@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ulf.hansson@linaro.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).