From: Arnd Bergmann <arnd@arndb.de>
To: gregkh@linuxfoundation.org
Cc: Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com>,
Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>,
Chris Park <chris.park@atmel.com>, Tony Cho <tony.cho@atmel.com>,
Glen Lee <glen.lee@atmel.com>, Leo Kim <leo.kim@atmel.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: wilc1000: restore wilc_spi_dev variable
Date: Fri, 16 Oct 2015 22:05:34 +0200 [thread overview]
Message-ID: <4978401.AVrDN2jmbq@wuerfel> (raw)
A recent change to wilc1000 accidentally deleted an important
variable, so we now get a build error when the SPI mode is
selected:
ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!
This partially reverts the broken commit to put the variable back.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 56293ff232b9 ("staging: wilc1000: linux_wlan_spi: include header")
---
Found on ARM randconfig builds.
diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wilc1000/linux_wlan_spi.c
index 760b72a9a6ff..039d06192d6b 100644
--- a/drivers/staging/wilc1000/linux_wlan_spi.c
+++ b/drivers/staging/wilc1000/linux_wlan_spi.c
@@ -41,6 +41,7 @@
static u32 SPEED = MIN_SPEED;
+struct spi_device *wilc_spi_dev;
void linux_spi_deinit(void *vp);
static int __init wilc_bus_probe(struct spi_device *spi)
next reply other threads:[~2015-10-16 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 20:05 Arnd Bergmann [this message]
2015-10-18 9:29 ` [PATCH] staging: wilc1000: restore wilc_spi_dev variable Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4978401.AVrDN2jmbq@wuerfel \
--to=arnd@arndb.de \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=kholmanskikh.s.s@gmail.com \
--cc=leo.kim@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).