Re: [RFC][PATCH v2] p54usb: rx refill revamp

[Artur Skawina <art.08.09@gmail.com>]

Artur Skawina wrote:
> Christian Lamparter wrote:
>> On Saturday 24 January 2009 05:18:07 Artur Skawina wrote:
>>> [My version schedules the work for every urb, even the poisoned ones]
>> well, there's now a hard limit... no change of a endless loop now.
> 
> The whole point of the poisoning was to prevent resubmission when
> canceling the urbs -- if you work around that manually, you could just
> as well kill them, instead of poisoning.
> I don't understand why want to add extra code to the rx irq just to
> avoid scheduling a work when downing the i/f, and keep a nasty failure
> case. The difference in down() performance is not going to be measurable,
> and even if it was, it wouldn't matter.

Oh, and we could always do something like

        if (likely(atomic_read(&urb->reject)==0))
                queue_work(priv->common.hw->workqueue, &priv->rx_refill_work);

which should catch most cases then urbs are either killed or poisoned.

artur