Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup take 2

[Dave <kilroyd@googlemail.com>]

Andrey Borzenkov wrote:
> On 26 ?????? 2009 06:46:02 Pavel Roskin wrote:
>> Please run the patch itself through checkpatch.  It finds two errors:
>>
>> ERROR: trailing statements should be on next line
>> #163: FILE: drivers/net/wireless/orinoco/hermes.c:65:
>> +                       printk(stuff); } while (0)
>> +                       printk(stuff); } while (0)
>> ERROR: do not use assignment in if condition
>> #698: FILE: drivers/net/wireless/orinoco/orinoco_cs.c:167:
>> +       if ((last_ret = (ret)) != 0) \
>>
>> total: 2 errors, 0 warnings, 786 lines checked
> 
> Thank you. Modified patch attached, now without errors.

Reviewed-by: David Kilroy <kilroyd@googlemail.com>

As far as I can tell, all the changes address a checkpatch warning, and
shouldn't modify behaviour of the code.

I specifically took a close look at the HERMES_BYTES_TO_RECLEN,
HERMES_RECLEN_TO_BYTES, CS_CHECK macros since they have potential to
hose the drivers. Looked OK to me.


Thanks,

Dave.