linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: pat-lkml <pat-lkml@erley.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH resend] crda: rename nl_handle to nl_sock for libnl-2.0
Date: Wed, 28 Jan 2009 19:39:15 -0500	[thread overview]
Message-ID: <4980FAB3.9050706@erley.org> (raw)
In-Reply-To: <1233189164.16048.106.camel@johannes.local>

Johannes Berg wrote:
> On Wed, 2009-01-28 at 19:21 -0500, pat-lkml wrote:
>> Johannes Berg wrote:
>>> On Wed, 2009-01-28 at 18:44 -0500, pat-lkml wrote:
>>>> Upstream has renamed nl_handle to nl_sock.  Update crda to the new names
>>>> and add #define for libnl-1.1.
>>> But libnl-2.0 comes with a define too:
>>> #define nl_handle nl_sock
>>>
>>> you just need to include the right headers, no?
>>>
>>> johannes
>> dunno.... but I can't find it:
>>
>> libnl $ egrep "#define nl_handle" * -r
>> libnl $ git pull
>> Already up-to-date.
> 
> Ah. Grr. Just recently removed.
> 
> johannes

Which leads back around to my question, should I continue pushing
patches like this your way (after making sure the right patch is on the
right e-mail with the right description), or do we want to wait and I'll
just maintain the patches outside of git, and push them once libnl-2.0
hits?  On one hand, it makes testing both versions easier, on the other,
it makes a lot of little 'fix' commits like this.  I have no issues
maintaining these sorts of patches, but I don't want to do it if you
don't want them.

Pat

  reply	other threads:[~2009-01-29  0:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 23:44 [PATCH resend] crda: rename nl_handle to nl_sock for libnl-2.0 pat-lkml
2009-01-29  0:05 ` Johannes Berg
2009-01-29  0:21   ` pat-lkml
2009-01-29  0:32     ` Johannes Berg
2009-01-29  0:39       ` pat-lkml [this message]
2009-01-29 13:37         ` Johannes Berg
2009-01-29  4:50 ` Luis R. Rodriguez
  -- strict thread matches above, loose matches on Subject: below --
2009-02-01 21:52 [patch " pat-lkml
2009-02-02 23:18 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4980FAB3.9050706@erley.org \
    --to=pat-lkml@erley.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).