From: Kalle Valo <kalle.valo@nokia.com>
To: ext Johannes Berg <johannes@sipsolutions.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: convert to net_device_ops
Date: Fri, 30 Jan 2009 13:43:31 +0200 [thread overview]
Message-ID: <4982E7E3.3010104@nokia.com> (raw)
In-Reply-To: <1233314871.30970.10.camel@johannes.local>
ext Johannes Berg wrote:
> On Fri, 2009-01-30 at 12:17 +0100, Johannes Berg wrote:
>> On Tue, 2009-01-27 at 05:29 +1100, Stephen Hemminger wrote:
>>> Convert to new net_device_ops in 2.6.28 and later.
>>>
>>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>> John, please revert this commit for now, it's breaking monitor mode
>> injection (and thus AP mode) because the xmit handler assignment in
>> ieee80211_setup_sdata is not effective.
>
> Oh, for reference:
>
> commit e22cab741afdd1e9857ea9fe51e28a6fe3c97b90
> Author: Stephen Hemminger <shemminger@vyatta.com>
> Date: Tue Jan 27 05:29:25 2009 +1100
>
> mac80211: convert to net_device_ops
>
> Convert to new net_device_ops in 2.6.28 and later.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Yes, I can confirm that reverting this commit solves the hostapd
problems I have been seeing.
Kalle
next prev parent reply other threads:[~2009-01-30 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 18:29 [PATCH] mac80211: convert to net_device_ops Stephen Hemminger
2009-01-26 18:33 ` Johannes Berg
2009-01-30 11:17 ` Johannes Berg
2009-01-30 11:27 ` Johannes Berg
2009-01-30 11:27 ` Johannes Berg
2009-01-30 11:43 ` Kalle Valo [this message]
2009-01-30 18:36 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2009-01-30 12:35 Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4982E7E3.3010104@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).