From: Felix Fietkau <nbd@openwrt.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: Bob Copeland <me@bobcopeland.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com
Subject: Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code
Date: Sat, 31 Jan 2009 22:45:40 +0100 [thread overview]
Message-ID: <4984C684.5060601@openwrt.org> (raw)
In-Reply-To: <40f31dec0901311250q6a669849x1dfbf08d967787be@mail.gmail.com>
Nick Kossifidis wrote:
>>> My intention is to reimplement hw_htoclock to account for half/quarter
>>> rate so it'll soon be
>>> clock = ath5k_hw_htoclock(1, channel->hw_value);
>> AFAIK Sam's HAL might have a bug there. If I remember correctly, the MAC
>> runs at the same clock speed with Half/Quarter rate.
>> It's done that way in the legacy HAL. Though there is a possibility of
>> it being hardware dependent, I'm pretty sure that it is that way at least
>> on 5413.
>>
>
> Both HALs tweak clock this way on ar5212SetDeltaSlope on all chips. If
> clock depends on channel bandwidth for turbo it makes sense to also
> change on half/quarter rate operation.
Yeah, for the delta slope it may be the same, but not for the MAC, IMHO.
Check out ath_hal_mac_clks in the legacy HAL and Sam's HAL. I believe
the legacy HAL variant is correct in this case.
- Felix
next prev parent reply other threads:[~2009-01-31 21:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 2:31 [PATCH 5/5] ath5k: Update reset code Nick Kossifidis
2009-01-31 17:08 ` Bob Copeland
2009-01-31 18:48 ` [ath5k-devel] " Nick Kossifidis
2009-01-31 18:56 ` Felix Fietkau
2009-01-31 20:50 ` Nick Kossifidis
2009-01-31 21:45 ` Felix Fietkau [this message]
2009-01-31 22:38 ` Bob Copeland
2009-01-31 22:58 ` Nick Kossifidis
2009-02-01 4:41 ` Bob Copeland
2009-02-01 3:50 ` Nick Kossifidis
2009-02-01 4:05 ` Felix Fietkau
2009-02-01 4:50 ` Nick Kossifidis
2009-02-01 5:07 ` Felix Fietkau
2009-02-01 5:14 ` Nick Kossifidis
2009-02-03 16:24 ` Bob Copeland
2009-02-03 16:28 ` [ath5k-devel] " Nick Kossifidis
2009-02-04 4:52 ` Bob Copeland
2009-02-04 5:14 ` Nick Kossifidis
2009-02-04 6:58 ` Nick Kossifidis
2009-02-04 21:57 ` Nick Kossifidis
2009-02-05 15:51 ` Bob Copeland
2009-02-05 15:59 ` [ath5k-devel] " Maxim Levitsky
2009-02-05 21:06 ` Nick Kossifidis
2009-02-06 3:52 ` Bob Copeland
2009-02-07 5:03 ` Bob Copeland
2009-02-07 5:20 ` Nick Kossifidis
2009-02-07 14:39 ` Bob Copeland
2009-02-07 16:13 ` Nick Kossifidis
2009-02-08 17:56 ` John W. Linville
2009-02-08 18:01 ` Nick Kossifidis
2009-02-05 23:28 ` Nick Kossifidis
2009-02-06 3:50 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4984C684.5060601@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).