RE: [PATCH rtw-next v3] wifi: rtw89: set RA init rate level when the station RSSI is known

[Ping-Ke Shih <pkshih@realtek.com>]

Vincent Schurink <spam@acio.nl> wrote:

[...]

> @@ -747,14 +765,8 @@ void rtw89_phy_ra_assoc(struct rtw89_dev *rtwdev, struct rtw89_sta_link *rtwsta_
> 
>         rcu_read_unlock();
> 
> -       if (rssi > 40)
> -               ra->init_rate_lv = 1;
> -       else if (rssi > 20)
> -               ra->init_rate_lv = 2;
> -       else if (rssi > 1)
> -               ra->init_rate_lv = 3;
> -       else
> -               ra->init_rate_lv = 0;
> +       ra->init_rate_lv = rtw89_phy_ra_get_init_rate_lv(rtwsta_link);
> +       rtwsta_link->ra_rssi_unknown = !ra->init_rate_lv;

Not only RSSI 0 but RSSI 1 can fall into this case, but I think it is harmless.

How about put into ra-> instead of rtwsta_link-> ?

Please put it on bottom with a comment like below, because the struct rtw89_ra_info
is a copy of H2C command (at initial version).

@@ -5235,6 +5235,8 @@ struct rtw89_ra_info {
        u8 macid_msb:2;
        u8 band:2; /* enum rtw89_band */
        u8 is_new_dbgreg:1;
+       /* driver helpers */
+       bool rssi_unknown:1;
 };


>         ra->upd_all = 1;
>         rtw89_debug(rtwdev, RTW89_DBG_RA,
>                     "ra assoc: macid = %d, mode = %d, bw = %d, nss = %d, lv = %d",
> --
> 2.53.0