linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: disable IBSS beacon before join
@ 2009-02-06 14:29 Johannes Berg
  2009-02-06 14:58 ` Larry Finger
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2009-02-06 14:29 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/main.c |    2 ++
 1 file changed, 2 insertions(+)

--- wireless-testing.orig/net/mac80211/main.c	2009-02-06 14:36:09.000000000 +0100
+++ wireless-testing/net/mac80211/main.c	2009-02-06 14:45:25.000000000 +0100
@@ -210,6 +210,8 @@ int ieee80211_if_config(struct ieee80211
 					!!rcu_dereference(sdata->u.ap.beacon);
 				break;
 			case NL80211_IFTYPE_ADHOC:
+				conf.enable_beacon = !!sdata->u.sta.probe_resp;
+				break;
 			case NL80211_IFTYPE_MESH_POINT:
 				conf.enable_beacon = true;
 				break;



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mac80211: disable IBSS beacon before join
  2009-02-06 14:29 [PATCH] mac80211: disable IBSS beacon before join Johannes Berg
@ 2009-02-06 14:58 ` Larry Finger
  2009-02-06 20:48   ` Johannes Berg
  2009-02-07 14:14   ` [PATCH v2] " Johannes Berg
  0 siblings, 2 replies; 4+ messages in thread
From: Larry Finger @ 2009-02-06 14:58 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John Linville, linux-wireless

Johannes Berg wrote:
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---

This patch needs a more-definitive commit message. In the git log, one
won't see the diff, and will have no idea what it does.

Larry


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mac80211: disable IBSS beacon before join
  2009-02-06 14:58 ` Larry Finger
@ 2009-02-06 20:48   ` Johannes Berg
  2009-02-07 14:14   ` [PATCH v2] " Johannes Berg
  1 sibling, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2009-02-06 20:48 UTC (permalink / raw)
  To: Larry Finger; +Cc: John Linville, linux-wireless

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

On Fri, 2009-02-06 at 08:58 -0600, Larry Finger wrote:
> Johannes Berg wrote:
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---
> 
> This patch needs a more-definitive commit message. In the git log, one
> won't see the diff, and will have no idea what it does.

Yeah, it should have some more text, I just couldn't think of anything
more elaborate than the subject. Will come up with something and repost,
I guess.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] mac80211: disable IBSS beacon before join
  2009-02-06 14:58 ` Larry Finger
  2009-02-06 20:48   ` Johannes Berg
@ 2009-02-07 14:14   ` Johannes Berg
  1 sibling, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2009-02-07 14:14 UTC (permalink / raw)
  To: Larry Finger; +Cc: John Linville, linux-wireless

Before we have a probe response frame (which is used as the
beacon too) there's no need to ask drivers to beacon, they
will not get a beacon anyway.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/main.c |    2 ++
 1 file changed, 2 insertions(+)

--- wireless-testing.orig/net/mac80211/main.c	2009-02-06 14:36:09.000000000 +0100
+++ wireless-testing/net/mac80211/main.c	2009-02-06 14:45:25.000000000 +0100
@@ -210,6 +210,8 @@ int ieee80211_if_config(struct ieee80211
 					!!rcu_dereference(sdata->u.ap.beacon);
 				break;
 			case NL80211_IFTYPE_ADHOC:
+				conf.enable_beacon = !!sdata->u.sta.probe_resp;
+				break;
 			case NL80211_IFTYPE_MESH_POINT:
 				conf.enable_beacon = true;
 				break;



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-02-07 14:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-06 14:29 [PATCH] mac80211: disable IBSS beacon before join Johannes Berg
2009-02-06 14:58 ` Larry Finger
2009-02-06 20:48   ` Johannes Berg
2009-02-07 14:14   ` [PATCH v2] " Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).