Re: [PATCH 3/3] mac80211: Modul. mesh path prot: Skeleton Module

[Florian Sesser <flomaillist@cosetrain.com>]

Hi!

Johannes, thanks for all of your comments! I will need some time to work
through them, though, please be patient.

Johannes Berg wrote:
> 00-0F-0F   (hex)                Real ID Technology Co., Ltd.
> 000F0F     (base 16)            Real ID Technology Co., Ltd.
>                                 9F Hanmi B/D 192-19
>                                 Nonhyeon-Dong
>                                 Gangnam-Gu Seoul 135-010
>                                 KOREA, REPUBLIC OF
> 
> Have you asked them about using their OUI?

Nah, sorry about that - I didn't get 0x000FACFF meant 'null' in the
first place, and since I don't have access to an OUI yet, I selected
this value by random. I still hope nobody seriously wants my skeleton
module in the kernel code though.

BTW... do you know which OUI in that case (at devel time, this is an
university project, afaik the university does not have an OUI I can use)
makes sense for stuff like that? I believe there is a reserved range,
but I don't know for what reason it's reserved, and if I should use it
to avoid misunderstandings.

>> +config MAC80211_MESH_PP_TEST
>> +	tristate "80211s: Path selection protocol test module"
>> +	default n
>> +	depends on MAC80211_MESH && MAC80211 && EXPERIMENTAL && m
> 
> && m ???

Limits the tristate to 'n' or 'm', because I didn't want to clutter the
code with ifdefs for the 'compiled-in' case. This cannot be the final
solution either. I need to investigate some more on what happens if I
just compile it in.

[do you really think I should to copy the style of rate control? i don't
like it at all. they have KBs of (IMHO) not very useful code instead of
keeping it to the point? Even in the Kconfig. Please correct me if I got
this wrong.]

> Generally, this looks like a decent idea,

Thanks :)

> but the execution definitely is lacking.

I know that, as I'm pretty new to kernel coding. Should I get me some
mentor from the kernel mentors project, or are you willing to correct my
stupid beginner mistakes all the time?

Also: As you still haven't said anything about my ops struct, I deem you
think I have made a somewhat reasonable selection here?

Again, thanks a lot!

Florian