From: Roel Kluin <roel.kluin@gmail.com>
To: flamingice@sourmilk.net
Cc: linux-wireless@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] p54: misplaced parentheses
Date: Sun, 15 Feb 2009 16:27:24 +0100 [thread overview]
Message-ID: <4998345C.9050409@gmail.com> (raw)
Only FIF_FCSFAIL is set due to parentheses
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
// include/net/mac80211.h vi +1133
enum ieee80211_filter_flags {
FIF_PROMISC_IN_BSS = 1<<0,
...
};
diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
index 34561e6..530daee 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -1932,8 +1932,8 @@ static void p54_configure_filter(struct ieee80211_hw *dev,
struct p54_common *priv = dev->priv;
*total_flags &= FIF_PROMISC_IN_BSS |
- (*total_flags & FIF_PROMISC_IN_BSS) ?
- FIF_FCSFAIL : 0;
+ (*total_flags & FIF_PROMISC_IN_BSS ?
+ FIF_FCSFAIL : 0);
priv->filter_flags = *total_flags;
reply other threads:[~2009-02-15 15:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4998345C.9050409@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).