From: Daniel Drake <dsd@gentoo.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC] zd1211rw: remove zd_addr_t typedef for a simple u16
Date: Tue, 10 Mar 2009 09:26:11 -0400 [thread overview]
Message-ID: <49B66A73.4030408@gentoo.org> (raw)
In-Reply-To: <1236651030-10331-1-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> The __nocast attribute is used to shut sparse up but we
> don't need it, lets just use u16 directly.
Which warning does this remove?
The purpose of this system was (I think) to make it so that if you got
addr and value in the wrong order in calls to e.g. zd_ioread16() then
sparse would tell you about it. Looks like your patch would remove that
protection?
Admittedly it is a bit of a strange thing and no excuse for programmers
getting parameters in the wrong order.. if it needs to go then I'm happy
with whatever you decide.
Daniel
next prev parent reply other threads:[~2009-03-10 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 2:10 [RFC] zd1211rw: remove zd_addr_t typedef for a simple u16 Luis R. Rodriguez
2009-03-10 7:02 ` Hin-Tak Leung
2009-03-10 7:11 ` Luis R. Rodriguez
2009-03-10 18:23 ` Hin-Tak Leung
2009-03-10 13:26 ` Daniel Drake [this message]
2009-03-10 16:38 ` Luis R. Rodriguez
2009-03-10 18:49 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B66A73.4030408@gentoo.org \
--to=dsd@gentoo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).