linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] zd1211rw: remove zd_addr_t typedef for a simple u16
Date: Tue, 10 Mar 2009 14:49:20 -0400	[thread overview]
Message-ID: <49B6B630.4000301@gentoo.org> (raw)
In-Reply-To: <20090310163810.GA6140@tesla>

Luis R. Rodriguez wrote:
> It would seem to make the code cleaner and more legible but it just fixed a
> sparse warning for me. Unfortunately I don't have an old zydas hardware to
> test it with too though.

The line in question:
	if (int_num == CR_INTERRUPT) {

The usage of CR_INTERRUPT wrong here; in this specific case, we are not 
looking to match a register address. It's a separate constant which is 
also treated separately from register addresses in the zydas documentation.

CR_INTERRUPT should be replaced with 0x9510, or perhaps a new constant e.g.
#define INTR_STS1_MAC_INTERRUPT 0x9510

I'm afraid that I don't have any hardware here to test with either, but 
the above change should be safe enough to go through without testing.

Thanks,
Daniel


      reply	other threads:[~2009-03-10 18:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-10  2:10 [RFC] zd1211rw: remove zd_addr_t typedef for a simple u16 Luis R. Rodriguez
2009-03-10  7:02 ` Hin-Tak Leung
2009-03-10  7:11   ` Luis R. Rodriguez
2009-03-10 18:23     ` Hin-Tak Leung
2009-03-10 13:26 ` Daniel Drake
2009-03-10 16:38   ` Luis R. Rodriguez
2009-03-10 18:49     ` Daniel Drake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B6B630.4000301@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).