From: Kalle Valo <kalle.valo@nokia.com>
To: ext Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: Re: [RFC PATCH v2 3/4] mac80211: disable power save when scanning
Date: Sat, 14 Mar 2009 19:37:45 +0200 [thread overview]
Message-ID: <49BBEB69.6090301@nokia.com> (raw)
In-Reply-To: <1237051502.5235.102.camel@johannes.local>
ext Johannes Berg wrote:
> On Sat, 2009-03-14 at 19:14 +0200, Kalle Valo wrote:
>
>> + if (!ps || (local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))
>> + /*
>> + * with IEEE80211_HW_PS_NULLFUNC_STACK and power save
>> + * enabled the firmware sent a null frame when power save
>> + * was disabled, so we need to send a new null frame
>> + */
>> + ieee80211_send_nullfunc(local, sdata, 1);
>> +}
>
> Now I'm confused a little. I thought with PS_NULLFUNC_STACK the firmware
> _didn't_ send such frames.
That's a bug, good catch! It should be:
!(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK)
I'll fix that in v3.
Kalle
next prev parent reply other threads:[~2009-03-14 17:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 17:14 [RFC PATCH v2 0/4] mac80211: beacon filtering Kalle Valo
2009-03-14 17:14 ` [RFC PATCH v2 1/4] mac80211: decrease execution of the associated timer Kalle Valo
2009-03-14 17:18 ` Johannes Berg
2009-03-14 18:46 ` Kalle Valo
2009-03-14 19:33 ` Luis R. Rodriguez
2009-03-20 9:22 ` Kalle Valo
2009-03-20 9:42 ` Johannes Berg
2009-03-20 10:37 ` Kalle Valo
2009-03-20 10:41 ` Johannes Berg
2009-03-14 17:14 ` [RFC PATCH v2 2/4] mac80211: track beacons separately from the rx path activity Kalle Valo
2009-03-14 17:21 ` Johannes Berg
2009-03-14 19:45 ` Luis R. Rodriguez
2009-03-14 19:55 ` Johannes Berg
2009-03-14 20:19 ` Luis R. Rodriguez
2009-03-15 6:52 ` Kalle Valo
2009-03-14 17:14 ` [RFC PATCH v2 3/4] mac80211: disable power save when scanning Kalle Valo
2009-03-14 17:25 ` Johannes Berg
2009-03-14 17:37 ` Kalle Valo [this message]
2009-03-14 17:14 ` [RFC PATCH v2 4/4] mac80211: add beacon filtering support Kalle Valo
2009-03-14 17:28 ` Johannes Berg
2009-03-14 17:55 ` Kalle Valo
2009-03-14 20:18 ` Luis R. Rodriguez
2009-03-15 7:22 ` Kalle Valo
2009-03-15 17:59 ` Johannes Berg
2009-03-15 19:27 ` Luis R. Rodriguez
2009-03-15 20:10 ` Kalle Valo
2009-03-16 8:50 ` Jouni Malinen
2009-03-16 12:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BBEB69.6090301@nokia.com \
--to=kalle.valo@nokia.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).