Re: [RFC PATCH v2 1/4] mac80211: decrease execution of the associated timer

[Kalle Valo <kalle.valo@nokia.com>]

Johannes Berg wrote:
> On Sat, 2009-03-14 at 19:14 +0200, Kalle Valo wrote:
> 
>> +void ieee80211_sta_rx_notify(struct ieee80211_sub_if_data *sdata,
>> +			     struct ieee80211_hdr *hdr)
>> +{
>> +	/* timer triggers only when there is no unicast traffic */
>> +	if (!is_multicast_ether_addr(hdr->addr1))
>> +		mod_timer(&sdata->u.mgd.timer,
>> +			  jiffies + IEEE80211_MONITORING_INTERVAL);
>> +}
> 
> Do we really need the multicast check? The frame will be coming from the
> AP in managed mode in both cases, so why regard the data path as idle
> when we're receiving multicast traffic?

It seems that I had a good vacation because I can't remember anymore why 
I added the check :D Too bad that even the comment I wrote was next to 
useless.

I'll remove the multicast check because I don't see the point for it. 
And if in case I finally recall the reason I'll definitely add a better 
comment.

Thanks for all the review!

Kalle