From: Jiri Slaby <jirislaby@gmail.com>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, mcgrof@gmail.com, me@bobcopeland.com,
nbd@openwrt.org
Subject: Re: [PATCH 2/3] ath5k: Convert chip specific calibration data to a generic format
Date: Sun, 15 Mar 2009 21:32:18 +0100 [thread overview]
Message-ID: <49BD65D2.1040608@gmail.com> (raw)
In-Reply-To: <20090315201704.GB5246@makis>
On 15.3.2009 21:17, Nick Kossifidis wrote:
> +ath5k_get_pcdac_intercepts(struct ath5k_hw *ah, u8 min, u8 max, u8 *vp)
> +{
> + const static u16 intercepts3[] =
> + { 0, 5, 10, 20, 30, 50, 70, 85, 90, 95, 100 };
> + const static u16 intercepts3_2[] =
> + { 0, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100 };
Just for future, C99 section 6.11.5 says:
Storage-class specifiers
The placement of a storage-class specifier other than at the
beginning of the declaration specifiers in a declaration is
an obsolescent feature.
It means we should use 'static const' instead of 'const static'.
Otherwise it looks good, thanks.
next prev parent reply other threads:[~2009-03-15 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 20:17 [PATCH 2/3] ath5k: Convert chip specific calibration data to a generic format Nick Kossifidis
2009-03-15 20:32 ` Jiri Slaby [this message]
2009-03-15 20:44 ` Nick Kossifidis
2009-03-15 20:46 ` Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2009-03-10 10:33 Nick Kossifidis
2009-03-10 12:44 ` Jiri Slaby
2009-03-10 17:29 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BD65D2.1040608@gmail.com \
--to=jirislaby@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).