linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix RX path
@ 2009-03-24  7:46 Johannes Berg
  2009-03-24 14:46 ` Larry Finger
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-03-24  7:46 UTC (permalink / raw)
  To: John Linville; +Cc: Larry Finger, linux-wireless

My previous patch ("mac80211: remove mixed-cell and userspace MLME code")
was too obvious to me, so obvious that a stupid bug crept in. The IBSS
RX function must be invoked for IBSS, of course, not anything != IBSS.

Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/rx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/rx.c	2009-03-24 08:44:20.000000000 +0100
+++ wireless-testing/net/mac80211/rx.c	2009-03-24 08:44:34.000000000 +0100
@@ -1884,7 +1884,7 @@ ieee80211_rx_h_mgmt(struct ieee80211_rx_
 	if (ieee80211_vif_is_mesh(&sdata->vif))
 		return ieee80211_mesh_rx_mgmt(sdata, rx->skb, rx->status);
 
-	if (sdata->vif.type != NL80211_IFTYPE_ADHOC)
+	if (sdata->vif.type == NL80211_IFTYPE_ADHOC)
 		return ieee80211_ibss_rx_mgmt(sdata, rx->skb, rx->status);
 
 	if (sdata->vif.type == NL80211_IFTYPE_STATION)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: fix RX path
  2009-03-24  7:46 [PATCH] mac80211: fix RX path Johannes Berg
@ 2009-03-24 14:46 ` Larry Finger
  0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2009-03-24 14:46 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John Linville, linux-wireless

Johannes Berg wrote:
> My previous patch ("mac80211: remove mixed-cell and userspace MLME code")
> was too obvious to me, so obvious that a stupid bug crept in. The IBSS
> RX function must be invoked for IBSS, of course, not anything != IBSS.
> 
> Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>

It now works.

Larry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-24 14:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-24  7:46 [PATCH] mac80211: fix RX path Johannes Berg
2009-03-24 14:46 ` Larry Finger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).