linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: How does rfkill work?
Date: Thu, 02 Apr 2009 09:44:32 -0500	[thread overview]
Message-ID: <49D4CF50.2060100@lwfinger.net> (raw)
In-Reply-To: <1238666206.4141.12.camel@johannes.local>

Johannes Berg wrote:
> Larry,
>=20
>> I'm having trouble getting the radio LED to work on b43legacy. When =
the LED's
>> are registered, I get LED index 0 registered with names of "b43legac=
y-phy0::tx"
>> and "b43legacy-phy0::rx", and LED index 1 with a name as of
>> "b43legacy-phy0::radio". I placed printk's at the entrance to
>> b43legacy_led_brightness_set(), which is the callback routine. I see=
 a number of
>> calls to modify LED index 0, which I assume are due to RX/TX activit=
y, but only
>> a single call for LED index 1 when the LED's are still being registe=
red. There
>> are no such calls generated when the radio switch is moved.
>>
>> I don't see where/how a particular LED is attached to the rfkill eve=
nt. Could
>> you point me to some code that does that?
>=20
> In theory, that is here:
>=20
>                 snprintf(name, sizeof(name),
>                          "b43legacy-%s::radio", wiphy_name(hw->wiphy)=
);
>                 b43legacy_register_led(dev, &dev->led_radio, name,
>                                  b43legacy_rfkill_led_name(dev),
>                                  led_index, activelow);
>=20
> I actually thought this was attached, by default, to the mac80211 rad=
io
> trigger, not the rfkill radio trigger.
>=20
> Can you check the contents of
> 	/sys/class/leds/b43legacy-...::radio/trigger
> please?

The first thing I noticed is that "radio" gets truncated to "rad", thus=
 the file
is /sys/class/leds/b43legacy-phy0\:\:rad/trigger, with contents "none i=
de-disk
ADP1-online BAT0-charging-or-full BAT0-charging BAT0-full phy0rx phy0tx
phy0assoc phy0radio [(]". I unloaded and reloaded the driver and found =
that the
"[(]" characters changed to "[=EF=BF=BDW[=EF=BF=BD]". It appears that s=
omething is putting
garbage in that file.

Larry


Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-04-02 14:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  4:59 How does rfkill work? Larry Finger
2009-04-02  9:56 ` Johannes Berg
2009-04-02 14:44   ` Larry Finger [this message]
2009-04-02 15:02     ` Johannes Berg
2009-04-02 15:22       ` Larry Finger
2009-04-02 15:55         ` Johannes Berg
2009-04-02 16:27         ` Johannes Berg
2009-04-02 18:18           ` Larry Finger
2009-04-02 18:28             ` Johannes Berg
2009-04-03 15:15               ` Richard Purdie
2009-04-03 19:22                 ` Johannes Berg
2009-04-02 18:29             ` Johannes Berg
2009-04-02 18:42               ` Larry Finger
2009-04-02 18:48                 ` Johannes Berg
2009-04-02 18:57                   ` Johannes Berg
2009-04-02 20:36                     ` Larry Finger
2009-04-02 20:50                       ` Johannes Berg
2009-04-02 21:24                         ` Larry Finger
2009-04-02 21:39                           ` Johannes Berg
2009-04-02 21:59                             ` Larry Finger
2009-04-02 22:09                               ` Johannes Berg
2009-04-03  4:37                       ` Marcel Holtmann
2009-04-03  4:57                         ` Larry Finger
2009-04-03  5:09                         ` Kay Sievers
2009-04-03  4:35       ` Marcel Holtmann
2009-04-03  9:01         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D4CF50.2060100@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).