Re: How does rfkill work?

[Larry Finger <Larry.Finger@lwfinger.net>]

Johannes Berg wrote:
> On Thu, 2009-04-02 at 16:24 -0500, Larry Finger wrote:
> 
>>> Actually. Are you positive it works without my patch? The confusing this
>>> is that this code never seems to call led_trigger_event() outside of
>>> rfkill_led_trigger_activate() which is only called once... Can you try
>>> this patch please?
>> No, it hasn't worked for some time, but until you rationalized the rfkill code,
>> I didn't want to mess with it. :)
> 
> Ah, ok :) And I thought I broke it.
> 
>> This patch does the trick. Not only is the set brightness callback routine being
>> called, but the LED is going on/off as expected. 
> 
> Wohoo!
> 
>> It even ends up in the off
>> state when the module is loaded with the switch off. 
> 
> Yeah I'd fixed that earlier by calling the right thing.
> 
>> It toggles on/off in that
>> case, but I'm not going to complain as long as it ends up off. That part broke
>> first, then everything broke later..
> 
> Hm, don't see a good way to fix that really. Nor am I sure why it
> happens, but if it just flashes once doesn't really matter I guess.
> 
> I'll roll this into my rework patch.

The whole thing gets a Tested-by: Larry Finger <Larry.Finger@lwfinger.net>