* [PATCH] leds: Increase trigger name maximum size
@ 2009-04-02 18:36 Larry Finger
2009-04-02 22:06 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2009-04-02 18:36 UTC (permalink / raw)
To: rpurdie; +Cc: linux-kernel, linux-wireless
On my HP dv2815 laptop, the total length of the triggers for my b43legacy
wireless device exceeds the maximum value of 50 defined in
include/linux/leds.h. As a result, the list is garbled.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Richard,
This is 2.6.31 material.
Larry
---
Index: wireless-testing/include/linux/leds.h
===================================================================
--- wireless-testing.orig/include/linux/leds.h
+++ wireless-testing/include/linux/leds.h
@@ -74,7 +74,7 @@ extern void led_classdev_resume(struct l
*/
#ifdef CONFIG_LEDS_TRIGGERS
-#define TRIG_NAME_MAX 50
+#define TRIG_NAME_MAX 70
struct led_trigger {
/* Trigger Properties */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds: Increase trigger name maximum size
2009-04-02 18:36 [PATCH] leds: Increase trigger name maximum size Larry Finger
@ 2009-04-02 22:06 ` Larry Finger
2009-04-03 14:45 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2009-04-02 22:06 UTC (permalink / raw)
To: rpurdie; +Cc: linux-kernel, linux-wireless
Larry Finger wrote:
> On my HP dv2815 laptop, the total length of the triggers for my b43legacy
> wireless device exceeds the maximum value of 50 defined in
> include/linux/leds.h. As a result, the list is garbled.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
Richard,
Please drop this. That length change is a red herring. Something is corrupting
the list of triggers, but this length is not it.
Sorry for the noise.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: Increase trigger name maximum size
2009-04-02 22:06 ` Larry Finger
@ 2009-04-03 14:45 ` Richard Purdie
0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2009-04-03 14:45 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-kernel, linux-wireless
On Thu, 2009-04-02 at 17:06 -0500, Larry Finger wrote:
> Larry Finger wrote:
> > On my HP dv2815 laptop, the total length of the triggers for my b43legacy
> > wireless device exceeds the maximum value of 50 defined in
> > include/linux/leds.h. As a result, the list is garbled.
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > ---
>
> Richard,
>
> Please drop this. That length change is a red herring. Something is corrupting
> the list of triggers, but this length is not it.
>
> Sorry for the noise.
I was about to raise some concerns about this patch as its just hiding
some underlying memory corruption. I don't think this is related to the
LED code but let me know if it turns out to be.
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-03 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-02 18:36 [PATCH] leds: Increase trigger name maximum size Larry Finger
2009-04-02 22:06 ` Larry Finger
2009-04-03 14:45 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).