Re: [RFT/RFC] rtl8187: Implement TX/RX blink for LED

[Larry Finger <Larry.Finger@lwfinger.net>]

Hin-Tak Leung wrote:
> 
> Thanks for the explanation. Depending (silently) on other kernel
> requirements is certainly fine.
> I am just thinking we can keep it simple, and wondering if we need
> another user-configurable option.

It is not user configurable. The revised Kconfig selects it automatically if
MAC80211_LEDS is set and LEDS_CLASS is y or m. The user never sees it in the
configuration process.

> BTW, I had a hard lock-up on suspend - it hasn't happened for
> months... while the module doesn't suspend properly, I have
> unload-on-sleep configured and it has work mostly fine for some
> months.  The vendor code is quite lacking in suspend/resume support,
> and if you are going to prepare another iteration of the LED patch,
> please give this a thought.
> on possible problem with this.

Thanks for the heads up. I have not been able to suspend my computer due to
other problems, but I'll see what I can find.

On another subject, I have been working with the vendor driver from
rtl8187B_linux_26.1036.0708.2008. I stripped out a lot of the dead code and made
the modifications so that it compiles cleanly with kernel 2.6.30-rc1. I also
modified it to handle my RTL8187B stick with the 8187 ID. The driver scans OK,
but so far it has not associated with my WPA2 AP. My hope is to get it running
so that I can compare throughput with the current Linux driver.

Larry