linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* net/wireless/reg.c:1196: warning: ‘channel_after’ may be used uninitialised in this function
@ 2009-04-15 10:45 Alan Jenkins
  2009-04-15 10:58 ` Alan Jenkins
  0 siblings, 1 reply; 8+ messages in thread
From: Alan Jenkins @ 2009-04-15 10:45 UTC (permalink / raw)
  To: Luis R. Rodriguez; +Cc: linux-wireless@vger.kernel.org

On 4/10/09, Luis R. Rodriguez <lrodriguez@atheros.com> wrote:
> Thanks pavel, please try this patch:
>
> From 94505af850bd0961a86e2786238ac0bbe0c44615 Mon Sep 17 00:00:00 200=
1
> From: Luis R. Rodriguez <lrodriguez@atheros.com>
> Date: Fri, 10 Apr 2009 11:07:43 -0700
> Subject: [PATCH] cfg80211: fix bug while trying to process obeacon hi=
nts on
> init
>
> During initialization we would not have received any beacons
> so skip processing reg beacon hints, also adds a check to
> reg_is_world_roaming() for last_request before accessing its
> fields.

Hi again

I'm building wireless-testing to test the rfkill-rewrite patches on
top of.  I need to apply the patch referenced above as well.

When I applied the above patch, I noticed this unrelated warning

net/wireless/reg.c: In function =91wiphy_update_regulatory=92:
net/wireless/reg.c:1196: warning: =91channel_after=92 may be used
uninitialised in this function
net/wireless/reg.c:1196: note: =91channel_after=92 was declared here
net/wireless/reg.c:1196: warning: =91channel_before=92 may be used
uninitialised in this function
net/wireless/reg.c:1196: note: =91channel_before=92 was declared here

Looking at the code, I think it does need fixing.  There's even a
comment which says "this finds them (or not)" - and if they're not
found, channel_before / channel_after will be unset.

Regards
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2009-04-17 10:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-15 10:45 net/wireless/reg.c:1196: warning: ‘channel_after’ may be used uninitialised in this function Alan Jenkins
2009-04-15 10:58 ` Alan Jenkins
2009-04-15 13:02   ` John W. Linville
2009-04-15 14:17     ` BUG in freq_reg_info_regd Alan Jenkins
2009-04-15 15:09       ` [ath5k-devel] " Bob Copeland
2009-04-15 15:13         ` Alan Jenkins
2009-04-15 16:08           ` Bob Copeland
2009-04-17 10:22             ` Alan Jenkins

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).