From: Richard Farina <sidhayn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: report operating frequency rather than current
Date: Mon, 04 May 2009 13:50:29 -0400 [thread overview]
Message-ID: <49FF2AE5.6040104@gmail.com> (raw)
In-Reply-To: <1241452330.8683.49.camel@johannes.local>
Johannes Berg wrote:
> It's not very helpful to see, in iwconfig, the current frequency
> the card is tuned to if that frequency is currently somewhere
> across the board because we're scanning. Since we keep track of
> the frequency the user wants, display that instead.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> net/mac80211/wext.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- wireless-testing.orig/net/mac80211/wext.c 2009-05-04 17:41:53.000000000 +0200
> +++ wireless-testing/net/mac80211/wext.c 2009-05-04 17:42:02.000000000 +0200
> @@ -185,7 +185,7 @@ static int ieee80211_ioctl_giwfreq(struc
> if (sdata->vif.type == NL80211_IFTYPE_ADHOC)
> return cfg80211_ibss_wext_giwfreq(dev, info, freq, extra);
>
> - freq->m = local->hw.conf.channel->center_freq;
> + freq->m = local->oper_channel->center_freq;
> freq->e = 6;
>
> return 0;
>
>
>
Nack. People should see the hardware channel. If I set channel 6 and my
wifi card is on channel 11 I need to see 11 not 6. Doesn't make any
sense to show some imaginary idealistic "I wish it was on channel 6"
when the hardware is on channel 11. Am I missing something here?
Thanks,
Rick Farina
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2009-05-04 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 15:52 [PATCH] mac80211: report operating frequency rather than current Johannes Berg
2009-05-04 17:50 ` Richard Farina [this message]
2009-05-04 18:02 ` Johannes Berg
2009-05-04 18:11 ` Richard Farina
2009-05-04 18:13 ` John W. Linville
2009-05-04 18:53 ` Fabio Rossi
2009-05-04 19:23 ` Luis R. Rodriguez
2009-05-05 5:45 ` Kalle Valo
2009-05-05 18:32 ` Richard Farina
2009-05-05 18:49 ` Johannes Berg
2009-05-05 18:57 ` Johannes Berg
2009-05-04 18:15 ` Johannes Berg
2009-05-04 18:30 ` Richard Farina
2009-05-04 18:33 ` Luis R. Rodriguez
2009-05-04 18:36 ` Johannes Berg
2009-05-04 18:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FF2AE5.6040104@gmail.com \
--to=sidhayn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox