From: Larry Finger <Larry.Finger@lwfinger.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [Bug #13319] Page allocation failures with b43 and p54usb
Date: Sun, 17 May 2009 18:16:21 -0500 [thread overview]
Message-ID: <4A109AC5.7040008@lwfinger.net> (raw)
In-Reply-To: <20090516163610.8a012268.akpm@linux-foundation.org>
Andrew Morton wrote:
>
> Well.. order-1 GFP_ATOMIC allocations are unreliable. The networking
> code should hanlde the situation and recover. I assume that is
> happening in this case?
Yes, the driver has recovered in all cases so far.
> Perhaps we did something in that code after 2.6.29 which increased the
> frequency of the order-1 allocation attempts? Maybe earlier kernels
> used order-0 all the time? Those are much more reliable.
I think something happened to change the allocation as I never saw these O(1)
failures before with these particular drivers. I put in a few test printk's and
the buffers were 700-800 bytes long, and I would not expect them to require more
than an O(0) allocation.
I pushed 2.6.30-rc6 hard for ~12 hours without any recurrence of the problem.
Given the relative infrequency of the error, this certainly does not indicate a
fix in recent code. I will be trying to force it again.
Larry
next prev parent reply other threads:[~2009-05-17 23:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 19:14 2.6.30-rc6: Reported regressions from 2.6.29 Rafael J. Wysocki
[not found] ` <385Pu-agh7M.A.SU.iYzDKB@chimera>
2009-05-16 23:36 ` [Bug #13319] Page allocation failures with b43 and p54usb Andrew Morton
2009-05-17 23:16 ` Larry Finger [this message]
2009-05-18 6:31 ` Pekka Enberg
2009-05-17 7:33 ` 2.6.30-rc6: Reported regressions from 2.6.29 Ingo Molnar
2009-05-17 10:34 ` Rafael J. Wysocki
2009-05-18 14:57 ` Oleg Nesterov
2009-05-18 15:11 ` Ingo Molnar
2009-05-18 15:31 ` Oleg Nesterov
2009-05-18 15:32 ` Linus Torvalds
2009-05-18 15:45 ` Oleg Nesterov
2009-05-22 16:40 ` Linus Torvalds
2009-05-23 0:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A109AC5.7040008@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).